Skip to content

Commit

Permalink
AI code: remove more outdated TODOs
Browse files Browse the repository at this point in the history
Some more comments and explanations in Issue #3695.
  • Loading branch information
mattsc committed Dec 17, 2018
1 parent 8a7a5a1 commit ba4202c
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
6 changes: 1 addition & 5 deletions src/ai/actions.cpp
Expand Up @@ -417,7 +417,6 @@ void move_result::do_check_after()
set_error(E_FAILED_TELEPORT);
return;
}
///@todo 1.9 add 'new units spotted' failure mode

if (!unreach_is_ok_ && unit_location_!=to_) {
set_error(E_NOT_REACHED_DESTINATION);
Expand Down Expand Up @@ -471,7 +470,7 @@ void move_result::do_execute()
std::size_t num_steps = ::actions::move_unit_and_record(
/*std::vector<map_location> steps*/ route_->steps,
/*::actions::undo_list* undo_stack*/ nullptr,
/*bool continue_move*/ true, ///@todo 1.9 set to false after implementing interrupt awareness
/*bool continue_move*/ true,
/*bool show_move*/ !preferences::skip_ai_moves(),
/*bool* interrupted*/ nullptr,
/*::actions::move_unit_spectator* move_spectator*/ &move_spectator);
Expand Down Expand Up @@ -799,9 +798,6 @@ void recruit_result::do_execute()
}

synced_context::run_in_synced_context_if_not_already("recruit", replay_helper::get_recruit(u->id(), recruit_location_, recruit_from_), false, !preferences::skip_ai_moves());
//TODO: should we do something to pass use_undo = false in replays and ai moves ?
//::actions::recruit_unit(*u, get_side(), recruit_location_, recruit_from_,
// !preferences::skip_ai_moves(), false);

set_gamestate_changed();
try {
Expand Down
1 change: 0 additions & 1 deletion src/ai/contexts.cpp
Expand Up @@ -1163,7 +1163,6 @@ void readonly_context_impl::recalculate_move_maps() const
++it;
}
}
///@todo: shall possible moves be modified as well ?
}
}
move_maps_valid_ = true;
Expand Down
1 change: 0 additions & 1 deletion src/ai/manager.hpp
Expand Up @@ -48,7 +48,6 @@ namespace ai
/**
* Base class that holds the AI and current AI parameters.
* It is an implementation detail.
* @todo 1.9 move it out of public view
*/
class holder{
public:
Expand Down

0 comments on commit ba4202c

Please sign in to comment.