Optimize wmliterator.isDirective()

Skips an unecessary for loop and if conditional.
wesnoth · Jul 27, 2015 · bd23c32 · bd23c32
1 parent de864c0
commit bd23c32
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/data/tools/wesnoth/wmliterator.py b/data/tools/wesnoth/wmliterator.py
@@ -49,14 +49,13 @@ def wmlfindin(element, scopeElement, wmlItor):
                 return itor
     return None
 
+
 def isDirective(elem):
     "Identify things that shouldn't be indented."
     if isinstance(elem, WmlIterator):
         elem = elem.element
-    for prefix in ("#ifdef", "#ifndef", "#ifhave", "#ifnhave", "#ifver", "#ifnver", "#else", "#endif", "#define", "#enddef", "#undef"):
-        if elem.startswith(prefix):
-            return True
-    return False
+    return elem.startswith(("#ifdef", "#ifndef", "#ifhave", "#ifnhave", "#ifver", "#ifnver", "#else", "#endif", "#define", "#enddef", "#undef"))
+
 
 def isCloser(elem):
     "Are we looking at a closing tag?"