log/windows: Fix missing class member initializer

This had the confusing side-effect of making some code in wesnoth.cpp believe it was safe to prompt the user to press Enter when NOT using --wconsole on my system, because the flag ended up with a true value by default. This is why you don't leave integral-type variables uninitialized, ever.
wesnoth · Oct 26, 2020 · cb867c0 · cb867c0
1 parent 4abeef2
commit cb867c0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/changelog.md b/changelog.md
@@ -2,6 +2,8 @@
  ### Language and i18n
    * Updated translations: British English, Catalan, French, Japanese, Polish,
      Portuguese (Brazil)
+ ### Miscellaneous and Bug Fixes
+   * Fixed a rare issue on Windows that could result in wesnoth.exe sticking around waiting for console input after encountering an error despite not being launched with the `--wconsole` option.
 
 ## Version 1.14.14
  ### Add-ons client

diff --git a/src/log_windows.cpp b/src/log_windows.cpp
@@ -284,6 +284,7 @@ log_file_manager::log_file_manager(bool native_console)
 	: fn_(unique_log_filename())
 	, cur_path_()
 	, use_wincon_(console_attached())
+	, created_wincon_(false)
 {
 	DBG_LS << "Early init message\n";