replace impossible check with assert.

since we refactored gamestate construction to initialize units last, it is no longer possible that resources::filter_con is a nullptr here.
wesnoth · Oct 27, 2018 · cc5aac7 · cc5aac7
1 parent 783dc07
commit cc5aac7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/units/unit.cpp b/src/units/unit.cpp
@@ -2169,8 +2169,8 @@ void unit::add_modification(const std::string& mod_type, const config& mod, bool
 	for(const config& effect : mod.child_range("effect")) {
 		// Apply SUF.
 		if(const config& afilter = effect.child("filter")) {
-			// @FIXME: during gamestate construction resources::filter_con is not available
-			if(resources::filter_con && !unit_filter(vconfig(afilter)).matches(*this, loc_)) {
+			assert(resources::filter_con);
+			if(!unit_filter(vconfig(afilter)).matches(*this, loc_)) {
 				continue;
 			}
 		}