Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gui2/ttransient_message: Hide title and image widgets when unused
When the title or image widget labels are left empty, the widgets continue to take up space in the grid, which is particularly conspicuous with our current border,border_size=all,5 convention. Commit 037ec6a exposes the underlying problem quite clearly in most dialogs because the image widget's cell takes up extra space to the left of the dialog while empty -- see the Objectives popup for an example. Hiding the relevant widgets when missing label values is trivial to do, even if it requires additional boilerplate in the gui2::ttransient_message case (no existing pre_show() method override), so it should be a good solution as any until cell borders gain the ability to become null when the contained widget is otherwise unused. NOTE: I had to move the inclusion of gettext.hpp around a bit in order to avoid name collisions with Boost headers introduced along with the two new GUI2 inclusions in transient_message.cpp. The _ gettext shorthand macro is truly a PITA to have near some of the most complicated Boost libraries.
- Loading branch information