Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement tiling options in the storyscreen #1027

Closed
CelticMinstrel opened this issue May 4, 2017 · 9 comments
Closed

Reimplement tiling options in the storyscreen #1027

CelticMinstrel opened this issue May 4, 2017 · 9 comments
Labels
Blocker: New Stable Issues that must be resolved prior to the next stable series being released. Bug Issues involving unexpected behavior. Regression Issues that were not present in previous releases. UI User interface issues, including both back-end and front-end issues.
Milestone

Comments

@CelticMinstrel
Copy link
Member

The old storyscreen supported a number of tiling options. The GUI2 version does not. This needs fixing.

@CelticMinstrel CelticMinstrel added Blocker: New Stable Issues that must be resolved prior to the next stable series being released. Bug Issues involving unexpected behavior. UI User interface issues, including both back-end and front-end issues. labels May 4, 2017
@CelticMinstrel CelticMinstrel added this to the 1.14.0 milestone May 4, 2017
@CelticMinstrel CelticMinstrel modified the milestone: 1.14.0 May 15, 2017
@kallaballa
Copy link
Contributor

I'd like to look into this bug, but from your description i have no idea what the problem is. Could you please elaborate?

@CelticMinstrel
Copy link
Member Author

CelticMinstrel commented Dec 2, 2017

See the wiki for reference. There are several keys described there (under [background_layer]) that specify scaling and tiling options. These no longer function as advertised.

Since the new storyscreen is GUI2, this will require an expansion of the supported scaling and tiling options in the GUI2 canvas. I think the functions to do the actual work should be already implemented, so you just need to figure out when and where to call them, hopefully.

@AI0867
Copy link
Member

AI0867 commented Feb 1, 2018

Partially re-implemented in 4f79fed, but unless someone wants to modify the widgets, the WML interface should probably be changed.

@CelticMinstrel
Copy link
Member Author

So that's partial because it only supports the case where horizontal and vertical are set to the same value, I guess? Full support would require alteration of the GUI2 canvas WML as well.

@CelticMinstrel CelticMinstrel added the Regression Issues that were not present in previous releases. label Feb 3, 2018
@Vultraz
Copy link
Member

Vultraz commented Feb 6, 2018

Where the hell even is that commit? I can't find it.

@Vultraz Vultraz closed this as completed in 4e42be1 Feb 6, 2018
@Vultraz
Copy link
Member

Vultraz commented Feb 6, 2018

Anyway, fully implemented above.

@CelticMinstrel
Copy link
Member Author

Nice! Does that finally cover everything, then? It'd be nice to expand the test added by @AI0867 so that it covers more cases, too.

I'm kinda surprised (and slightly suspicious) that this seems to have been done without touching the GUI2 canvas code at all...

@AI0867
Copy link
Member

AI0867 commented Feb 7, 2018

As that commit was on a branch on my own fork, it was not actually 'added'. I've now added the testcase in 39c3f21.

@CelticMinstrel
Copy link
Member Author

Ah, okay. I guess that explains why vultraz couldn't find it... >_>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker: New Stable Issues that must be resolved prior to the next stable series being released. Bug Issues involving unexpected behavior. Regression Issues that were not present in previous releases. UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Development

No branches or pull requests

4 participants