New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement tiling options in the storyscreen #1027
Comments
I'd like to look into this bug, but from your description i have no idea what the problem is. Could you please elaborate? |
See the wiki for reference. There are several keys described there (under Since the new storyscreen is GUI2, this will require an expansion of the supported scaling and tiling options in the GUI2 canvas. I think the functions to do the actual work should be already implemented, so you just need to figure out when and where to call them, hopefully. |
Partially re-implemented in 4f79fed, but unless someone wants to modify the widgets, the WML interface should probably be changed. |
So that's partial because it only supports the case where horizontal and vertical are set to the same value, I guess? Full support would require alteration of the GUI2 canvas WML as well. |
Where the hell even is that commit? I can't find it. |
Anyway, fully implemented above. |
Nice! Does that finally cover everything, then? It'd be nice to expand the test added by @AI0867 so that it covers more cases, too. I'm kinda surprised (and slightly suspicious) that this seems to have been done without touching the GUI2 canvas code at all... |
As that commit was on a branch on my own fork, it was not actually 'added'. I've now added the testcase in 39c3f21. |
Ah, okay. I guess that explains why vultraz couldn't find it... >_> |
The old storyscreen supported a number of tiling options. The GUI2 version does not. This needs fixing.
The text was updated successfully, but these errors were encountered: