[standard_unit_filter] id = "" behaviour changed (GNA #22516)

[wesnoth-bugs]

Original submission by gfgtdf on 2014-08-24

in 1.13-dev the bahviour of unit filter has changed to that [filter] id # "" [/filter] which previously didn't match any unit now matches all units. this makes a difference sometimes esp when you say [filter] id "$myunit.id" [/filter] it previously didnt match any unit if myunit didn't exist. Now it macthes any unit. Is the new behaviour intended ?

(Reproduced on windows)
Release: 1.13.0-dev
Priority: 3 - Low
Severity: 3 - Normal

[wesnoth-bugs]

Modified on 2014-08-28

involution wrote:

I looked into this -- the code which I most recently posted to master about unit filters treats id="" the same as if the id field were blank. I didn't realize that it was important not to do that. I think all the fields of unit filter that take comma separated lists are affected, so not just ids, but also types, variations, abilities...

Ultimately it goes back to this line here:

https://github.com/wesnoth/wesnoth/blob/master/src/unit_filter.cpp#L107

I think I should be able to push a fix without much difficulty.

[wesnoth-bugs]

Modified on 2016-08-24

zookeeper wrote:

This still seems to be an issue.

zookeeper changed status: None -> Confirmed