"Delay Shroud Updates" should apply to recalls

[jostephd]

Hi,

Recalling a unit unveils the shroud, and hence is not undoable, even while "Delay Shroud Updates" is enabled.

To reproduce, enable "Delay Shroud Updates" and recall any dwarf onto (8,16) at the very start of HttT Hasty Alliance. The recall will unveil (4,13) and be non-undoable. I expect the recall not to unveil any hexes and to be undoable, until "Update Shroud Now" is invoked.

[jostephd]

I've tried to implement this by making place_recruit return early if team::auto_shroud_updates() is false, but then I ran into the undo list handling: actions::undo::recall_action unconditionally clears the shroud. I'm not sure how to proceed.

[AI0867]

This appears to be due to the initiative special, and its associated events. It triggers on all prerecruit and prerecall events, breaking undo for recall and traitless recruit.

[jostephd]

@AI0867 Thanks but I can still reproduce the original problem with current master (b4c08f4). Could you double check please?

[jostephd]

I think there are three separate issues here:

1. When recalling a merman onto (8,16), it was not possible to undo the recall. ca0b503 fixed that.
2. Now that it's possible to undo the recall, invoking "redo" causes a sync error. I just filed that as HttT: "initiative" special causes sync/checksum errors in recalls #2216.
3. Recalls don't honor the "Delay Shroud Updates" option. We can track that under Make the "Delay Shroud Updates" option apply to recalls. #2207.

Thanks for fixing (1), @AI0867.

[AI0867]

After my fix, recalls did appear to honor "delay shroud updates" in the tests I did in Hasty Alliance.

[jostephd]

With current master, if I start HttT anew, :create a dwarvish unit, :change_level to Hasty Alliance, enable Delay Shroud Updates and recall the unit onto (8,16), then shroud is removed from some hexes and the recall is not undoable. So it seems it's fixed for you but not for me..?