Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalionalize the tooltips of the logging options #2837

Closed
Gallaecio opened this issue Apr 6, 2018 · 10 comments
Closed

Internalionalize the tooltips of the logging options #2837

Gallaecio opened this issue Apr 6, 2018 · 10 comments
Assignees
Labels
Bug Issues involving unexpected behavior. Stable 1.14 Issues specific to the Wesnoth 1.14 maintenance branch. Translations Issues with translations, translation tooling, the translations engine, or code that uses it.
Milestone

Comments

@Gallaecio
Copy link

Gallaecio commented Apr 6, 2018

The tooltips that you see when you hover one of the check boxes at ‘Preferences → Advanced → Logging’ are currently not internationalized.

adrian@curros:~/proxectos/wesnoth/1.14$ grep "Info level logging" * -FIRi
data/gui/window/logging.cfg:                                                                                            {_GUI_LOGGER_RADIOS {_INFO} "Info level logging: more information"}
adrian@curros:~/proxectos/wesnoth/1.14$

It should be possible to translate the four strings that act as tooltips for those check boxes.

irydacea added a commit to irydacea/wesnoth that referenced this issue Apr 6, 2018
@irydacea irydacea added Bug Issues involving unexpected behavior. Postponed Issues which cannot be worked on at this time. Translations Issues with translations, translation tooling, the translations engine, or code that uses it. Stable 1.14 Issues specific to the Wesnoth 1.14 maintenance branch. labels Apr 6, 2018
@irydacea irydacea self-assigned this Apr 6, 2018
@irydacea irydacea reopened this Apr 6, 2018
@irydacea irydacea added this to the 1.14.1 milestone Apr 6, 2018
@CelticMinstrel
Copy link
Member

If you're doing this it'd be nice if you can also add a fifth column (for "do not log ever").

@irydacea
Copy link
Member

irydacea commented Apr 6, 2018

That seems completely out of the issue and PR's scope. I'm not even sure if that's a thing that the logging backend supports.

@CelticMinstrel
Copy link
Member

It is since recently which is why I brought it up.

@CelticMinstrel
Copy link
Member

(I guess it might be out of scope here though.)

@sevu
Copy link
Member

sevu commented Apr 26, 2018

It is since recently

   --log-level=domain1,domain2,...
          sets the severity level of the log domains.  all can be used to match any log domain. Available levels: error, warning, info, debug.  By default the error
          level is used.

How is the new logging level called?

@CelticMinstrel
Copy link
Member

@sevu If I recall correctly, I updated the manpage on master (and that update is also included in the list of commits that need backporting for 1.14.1). The new level is none.

@sevu
Copy link
Member

sevu commented Apr 27, 2018

Thanks. Speaking of which, the entry for the --log-strict options seems to be incorrect, it apparently needs an log-level as argument.

@irydacea
Copy link
Member

I'm handling the addition of a UI element for the log disable option in #2972.

irydacea added a commit that referenced this issue May 2, 2018
@irydacea irydacea closed this as completed May 2, 2018
@sevu
Copy link
Member

sevu commented May 3, 2018

Looking at this again:
The manpage tells By default the error level is used.
The UI about which this issue is has warning set by default.

I assume there are is no difference between the two and it's warning for both?

@sevu sevu removed the Postponed Issues which cannot be worked on at this time. label May 3, 2018
@irydacea
Copy link
Member

irydacea commented May 3, 2018

Correct. Fixed in commit 350865b.

jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues involving unexpected behavior. Stable 1.14 Issues specific to the Wesnoth 1.14 maintenance branch. Translations Issues with translations, translation tooling, the translations engine, or code that uses it.
Projects
None yet
Development

No branches or pull requests

4 participants