Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up PO files that include the "prefix^" in the msgstr #2965

Closed
stevecotton opened this issue Apr 25, 2018 · 1 comment
Closed

Clean up PO files that include the "prefix^" in the msgstr #2965

stevecotton opened this issue Apr 25, 2018 · 1 comment
Labels
Bug Issues involving unexpected behavior. Translations Issues with translations, translation tooling, the translations engine, or code that uses it.

Comments

@stevecotton
Copy link
Contributor

This is wrong but seems to work:

msgid "filesystem_path_system^Root"
msgstr "filesystem_path_system^Root"

For strings that have no translation, the part before the "^" will be removed. The example above shows "Root" because that no-translation handling is also done when the PO's msgstr is exactly the same as the msgid.

But this will later break if someone makes any change to the text, so it seems a good idea to clean it up. For example, this shows as "filesystem_path_system^Wurzel":

msgid "filesystem_path_system^Root"
msgstr "filesystem_path_system^Wurzel"
@irydacea irydacea added Bug Issues involving unexpected behavior. Translations Issues with translations, translation tooling, the translations engine, or code that uses it. labels Apr 25, 2018
@Wedge009
Copy link
Member

Wedge009 commented May 3, 2018

I suppose this happens when translators don't realise that they're supposed to remove the 'prefix^' part.

Wedge009 added a commit to Wedge009/wesnoth that referenced this issue Aug 24, 2019
@Wedge009
Remove description prefixes from translated strings. Resolves wesnoth…
1b01ee5 
…#2965.

* Where a translation is provided, I remove the description prefix.
* Where a translated string exactly matches the en_US source, or is otherwise still clearly English and doesn't match Google Translate's suggestions, I make it blank to indicate a non-translated string.
* Interestingly, there were some prefixes left-over in en_GB, presumably from before I took over.

[ci skip]
Wedge009 added a commit to Wedge009/wesnoth that referenced this issue Aug 24, 2019
@Wedge009
Remove description prefixes from translated strings. Resolves wesnoth…
fe6a9a3 
…#2965.

* Where a translation is provided, I remove the description prefix.
* Where a translated string exactly matches the en_US source, or is otherwise still clearly English and doesn't match Google Translate's suggestions, I make it blank to indicate a non-translated string.
* Interestingly, there were some prefixes left-over in en_GB, presumably from before I took over.

[ci skip]
@Wedge009 Wedge009 mentioned this issue Aug 24, 2019
Merged
Wedge009 added a commit that referenced this issue Aug 27, 2019
@Wedge009
Remove description prefixes from translated strings. Resolves #2965.
8ed35cd 
* Where a translation is provided, I remove the description prefix.
* Where a translated string exactly matches the en_US source, or is otherwise still clearly English and doesn't match Google Translate's suggestions, I make it blank to indicate a non-translated string.
* Interestingly, there were some prefixes left-over in en_GB, presumably from before I took over.

[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues involving unexpected behavior. Translations Issues with translations, translation tooling, the translations engine, or code that uses it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevecotton @irydacea @Wedge009