Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR S5 - Malifors Death dialogue somewhat bugged #3117

Closed
Konrad22 opened this issue May 15, 2018 · 8 comments
Closed

NR S5 - Malifors Death dialogue somewhat bugged #3117

Konrad22 opened this issue May 15, 2018 · 8 comments
Labels
Bug Issues involving unexpected behavior. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Good first issue Issues deemed adequate for contributors without prior experience to work on. WML Issues involving the WML engine or WML APIs.

Comments

@Konrad22
Copy link
Contributor

Konrad22 commented May 15, 2018

There is a dialogue that fires (no matter what) when I 'kill' Malifor with any unit of mine. It fires as well, if I kill him with my Mages of Light (who can kill him for good). (Therefor it's not exactly bugged, it's just missing a necessary check.)
NR-The Pursuit-Auto-Save66.gz
(Yes, I did cheat so I'd get Abhai. I might have maybe reached him if I fight the green undead long enough, but being unable to wipe them out after 60 turns is just unreasonable. I'm glad about the fix.)

@sevu sevu added Bug Issues involving unexpected behavior. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign WML Issues involving the WML engine or WML APIs. Good first issue Issues deemed adequate for contributors without prior experience to work on. labels May 15, 2018
@Byteron
Copy link
Contributor

Byteron commented May 16, 2018

You mean that these events should only be fired once?

@Konrad22
Copy link
Contributor Author

I mean that they shouldn't comment on Malifor being unable to be killed by normal means (and that only the Mages of Light can kill him) if they have already killed him for real on the first try.

@UnwiseOwl
Copy link
Contributor

You're right that there's no check, but I also don't think that it's possible to reach this state by normal means. How did you do the damage to Malifor in the first place? As I understand it he can't be hurt at all by anything other than white mages and that event should fire the first time that they attack him.

@Konrad22
Copy link
Contributor Author

So...
Let's list the events first.
Event 1: Dialogue that Malifor is unkillable except by the White Mages (told in a way like 'oops, we can't kill him like that, let's do it like this instead)
Event 2: Dialogue when Malifor was killed for real

Event 1 fires when Malifor is 'killed' for the first time
Event 2 fires when Malifor is killed by the White Mages

My situation: Malifor is being killed for the first time and I used the White Mages to kill him
Now: Event 1 fires. Event 1 ends. Event 2 fires.
My 'problem' is, Event 1 contains information you should have only found out by failing to kill him for real (by the way it's worded) and it sounds quite redundant when the two Events fire directly after another.

@UnwiseOwl
Copy link
Contributor

I'm assuming that your Event 1 is the dialogue that begins "I see now. It is impossible to destroy him by ordinary means." that triggers when Malifor is first attacked by Morvin or Thera. If other units attack him, they cannot kill him as they cannot do damage. If you were able to damage him using other means then that is a bug, which is why I asked about how you damaged him.

Since 1 white mage cannot kill Malifor, event 1 should never fire once Malifor is dead.

@Konrad22
Copy link
Contributor Author

Oh, I completly missed out on that because I never tried killing him with anything else. :O

I get your question now and I checked what I did. Malifor attacked them first and got badly damaged in return, that's why he was low enough to be finished off by one Mage of Light (or even by one White Mage). Him attacking them does not trigger Event 1. (Him attacking anyone does not trigger any 'Oh, I'm sooo invulnerable' Event.)

@UnwiseOwl
Copy link
Contributor

That'll do it.

changing:
[event] name=attack end [filter] id=Father Morvin,Sister Thera [/filter] [filter_second] id=Malifor [/filter_second]
to:

[event] name=attack end [filter] id=Father Morvin,Sister Thera, Malifor [/filter] [filter_second] id=Malifor,Father Morvin,Sister Thera [/filter_second]
should do the job.

@Konrad22
Copy link
Contributor Author

Thanks for your attention.

@sevu sevu closed this as completed in 913b77d Jun 4, 2018
sevu pushed a commit that referenced this issue Jun 4, 2018
* Fixes #3117 - Malifor damage event now occurs on defence as well as on attack

* Fixes #3116 - Doors to the study can now be opened from inside

[ci skip]
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018
NR S5a: bugfixes

* Fixes wesnoth#3117 - Malifor damage event now occurs on defence as well on attack

* Fixes wesnoth#3116: - Doors to the study can now be opened from inside

[ci skip]
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018
NR S5a: bugfixes

* Fixes wesnoth#3117 - Malifor damage event now occurs on defence as well on attack

* Fixes wesnoth#3116: - Doors to the study can now be opened from inside

[ci skip]

(cherry-picked from commit 913b77d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues involving unexpected behavior. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Good first issue Issues deemed adequate for contributors without prior experience to work on. WML Issues involving the WML engine or WML APIs.
Projects
None yet
Development

No branches or pull requests

4 participants