Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua CVE tests break pot-update #3436

Closed
stevecotton opened this issue Aug 5, 2018 · 4 comments
Closed

Lua CVE tests break pot-update #3436

stevecotton opened this issue Aug 5, 2018 · 4 comments
Labels
Blocker: New Stable Issues that must be resolved prior to the next stable series being released. Bug Issues involving unexpected behavior.
Milestone

Comments

@stevecotton
Copy link
Contributor

$ git checkout --detach origin/1.14
HEAD is now at 7e8088f updated Chinese (Traditional) translation (changelog)
$ scons pot-update
...
error: data/test/scenarios/test_cve_2018_1999023_2.cfg:4: UTF-8 Format error.
Can't decode byte 0x93 (invalid start byte).

@sevu sevu added Bug Issues involving unexpected behavior. Blocker: New Stable Issues that must be resolved prior to the next stable series being released. labels Aug 5, 2018
@CelticMinstrel
Copy link
Member

Is that file perhaps using "UTF-8 with BOM"?

jyrkive added a commit that referenced this issue Aug 5, 2018
@jyrkive jyrkive closed this as completed in 5bbc7fe Aug 5, 2018
@jyrkive
Copy link
Member

jyrkive commented Aug 5, 2018

@CelticMinstrel No, the file is pure binary. You need a hex editor to view or edit it.

@CelticMinstrel
Copy link
Member

A better fix is probably to change the file extension.

@jyrkive
Copy link
Member

jyrkive commented Aug 6, 2018

I also considered changing the extension. However, I found out that only files with the .cfg extension can be loaded as unit tests.

@sevu sevu added this to the 1.14.5 milestone Sep 14, 2018
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018
(cherry-picked from commit 5bbc7fe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker: New Stable Issues that must be resolved prior to the next stable series being released. Bug Issues involving unexpected behavior.
Projects
None yet
Development

No branches or pull requests

4 participants