Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a new unit disembarked,its description didn't appear in "units" of "help". #3813

Closed
gaojicainiao opened this issue Dec 27, 2018 · 8 comments
Labels
Units Issues that involve unit definitions or their implementation in the engine.
Milestone

Comments

@gaojicainiao
Copy link

When a new unit disembarked,its description didn't appear in "units" of "help".It shows"Unknown Unit",just likes that I didn't discover it.
I don't know if this is a bug.But I would like to report it.
I'm a Chinese and I'm not good at programming and written English,so maybe I won't relpy.I'm sorry about it.

@Wedge009 Wedge009 added the Units Issues that involve unit definitions or their implementation in the engine. label Dec 27, 2018
@Wedge009
Copy link
Member

First, thanks for your report.

I understand writing in another language is hard. There is an English saying that '1 picture is worth a 1000 words' - do you have a screenshot or image to help explain what you mean? 'Disembark' is usually related to ships - but there are few Wesnoth scenarios involving ships. I just wonder if you are referring to unit recruitment or something else.

@jostephd
Copy link
Member

Thanks for the report, @gaojicainiao. What scenario were you playing? Feel free to answer in Chinese if that's easier for you. Thanks again!

@gaojicainiao
Copy link
Author

I recoeded a video to show the problem.
I uninstalled the game and deleted all data of the game except the saved game.Then reinstalled it.Then I changed Chinese to English and load the saved game to record.
In the video,the disembarked units that I did't discover before has no description in "units" of "help".
So it should be a small problem.Less players will meet it because less boats to bring new units.
Don't worry about the names of the units which show incorrectly,bacause I changed Chinese to English,so the Chinese name can't show correctly,that's not a bug.
Thanks for your working on this game!
video.zip

@sevu
Copy link
Member

sevu commented Jan 5, 2019

Which campaign and scenario is this? And are there more scenarios where this occurs?

@gaojicainiao
Copy link
Author

Black Flag of Son of the Black-Eye.
I don't know if there's more.

@sevu sevu added this to the 1.14.6 milestone Jan 5, 2019
sevu added a commit that referenced this issue Jan 5, 2019
The engine does not do this by itself
(which would be a better soultion)

closes #3813
[ci skip]
@sevu sevu closed this as completed in fba83e7 Jan 5, 2019
@sevu
Copy link
Member

sevu commented Jan 5, 2019

Thank you. If you want you can the file and add the two lines.

@jostephd
Copy link
Member

jostephd commented Jan 5, 2019

@sevu I think you meant to say that @gaojicainiao can modify the file (in his wesnoth data directory) and add the two lines. (You missed a word)

Should a new issue be opened for making units placed via lua (also unit:to_map, etc) add themselves to known units?

@sevu
Copy link
Member

sevu commented Jan 5, 2019

Ah…indeed.

A new issue would be good, it was the 1st time discussed several month ago in regard to the same case in the tutorial, which is closed now.

Edit: created issue #3843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Units Issues that involve unit definitions or their implementation in the engine.
Projects
None yet
Development

No branches or pull requests

4 participants