Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use damage type and range icons in units database #3949

Closed
jostephd opened this issue Feb 26, 2019 · 4 comments
Closed

Use damage type and range icons in units database #3949

jostephd opened this issue Feb 26, 2019 · 4 comments
Labels
Enhancement Issues that are requests for new features or changes to existing ones. Good first issue Issues deemed adequate for contributors without prior experience to work on. Units Database Issues involving units.wesnoth.org and the wmlunits tool that generates it.
Projects
Damage type and range icons

Comments

@jostephd
Copy link
Member

Like #3732 #3740 #3940, but for the units database for 1.15+
@jostephd jostephd added Enhancement Issues that are requests for new features or changes to existing ones. Units Database Issues involving units.wesnoth.org and the wmlunits tool that generates it. Good first issue Issues deemed adequate for contributors without prior experience to work on. labels Feb 26, 2019
@jostephd jostephd added this to Damage type and range icons in Damage type and range icons Mar 20, 2019
@drzaal drzaal mentioned this issue Apr 6, 2019
Merged
soliton- pushed a commit that referenced this issue May 14, 2019
@drzaal @soliton-
Use damage type and range icons
9c6dcb6 
Fixes issue #3949
@jostephd
Copy link
Member Author

Fixed in #4016

@drzaal Thanks for fixing this! Next time, please include Fixes #3949 somewhere in the commit message so github will auto-close the issue as well.

@soliton-
Copy link
Member

That was my fault. I squashed the commits and wrote the commit message missing the proper format.

@jostephd
Copy link
Member Author

Ah, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Issues that are requests for new features or changes to existing ones. Good first issue Issues deemed adequate for contributors without prior experience to work on. Units Database Issues involving units.wesnoth.org and the wmlunits tool that generates it.
Projects
No open projects
Damage type and range icons
Damage type and range icons
Milestone
No milestone
Development

No branches or pull requests
3 participants
@soliton- @jostephd and others