-
-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.15 changed behavior of affect_allies #4257
Comments
What is this issue for compared to #4258? Is there any question whether the unintentional change should be corrected? |
This task is to revert/split affect_allies behavior. #4258 is whether to keep current unintentional state for leadership only. |
This behaviour is not documented in the wiki isn't it? I think that if we want to keep the tristate behviour it'd be better to name the tree state explicitly (and opf course to document them properly). Alterntiveley we coudl also add a new key somethign like affect_own_side that' also allow us to create abilities that affect allies only but not the same team (altough that shoudl alos be possibel with extded filters already.) |
Or a key that takes a list, something like 'affects=self, own_side, allied_sides, enemies'. |
There's another instance here: Line 166 in d3db923
but that struct member is unused, as far as I can tell. Making the WML key a tristate or a list is a good idea, but in the meantime I think the following would restore the old behavior (there's just no reason to change it, even if it's undocumented):
OK to push that? |
Confirmed that it's unused: I removed it from the hpp and from the constructor and wesnoth bult cleanly. Pushed the patch with minor changes to make the diff from the pre-2b65a8c5c8dfa0e58061d78f208499304805078a state even smaller. This is the result:
|
* tips: New tip about terrains. * Abilities: Revert an unintentional change of the behavior of affect_allies. Fixes wesnoth#4257 * switch from map_data to map_file in SP * add map_file to schema * remove TODOs regaring overlays * schema: Use same definition as in actionwml * updated Korean translation * Improve the terrain code's encapsulation (wesnoth#4411) Change terrain_type_data's documentation and some methods to avoid exposing implementation details, for example renaming try_merge_terrains to is_known. Move the code to load all the [terrain_types] in to the terrain_type_data class's own .cpp file, and out of terrain.cpp. Add documentation about "underlying", and why worst(best(a,b),c,d) terrains don't work The commented-out code for merging pluses and minuses in the middle of an alias was commented out in 1.5's d2edbe1, but the concept of pluses and minuses in the middle of an alias seems broken anyway (see comments added to merge_alias_lists in this commit). Descriptions are t_strings, avoid converting them to std::string and back. * Changelog entry for wesnoth#4411, terrain encapsulation * NR S06a: Fix the filter for Tallin complaining that they're sitting in the caves (wesnoth#4371) Now it only triggers if five or less units are outside. (cherry picked from commit 0be05d0) * updated Portuguese (Brazil) translation * Rename [unit_type_fix] to [modify_unit_type] for clarity. * Alter the special notes syntax in EffectWML so that the note macros can be reused in that context * updated Italian translation * fix [modify_side] controller=ai for the current side * Tutorial S02: Make the grunt cross the bridge without bait (wesnoth#4425) Not a code-revert, but a behavior-revert of the switch of this unit to use the guardian AI. 26327a5. If he somehow doesn't get across the bridge, warn the player that something has broken. (cherry picked from commit 656a446) * Experimental AI: fix poisoners ignoring [avoid] tag * Simple Attack Micro AI Demo: Update dialogue for 1.14's AI improvements (wesnoth#4431) The default 1.14 already considers high-XP attacks. Other than the dialogue, the only change is to reduce the AI's default aggression, so there's more contrast between what the Micro AI does compared to what the default AI does. Switched to typographic quotation marks in the dialogue, and removed double spaces between sentences. * Added labler action * Added some rules for the labler * Restrict labler to PRs being opened, enabled it for issues being opened * Remove issue trigger I don't think the labler action is meant to work with issues * WoV translation: it hasn't been translated into en@shaw I don't know what happened here, but c61b9b3 had WoV's en@shaw.po filled in with normal English. That's an error, this commit removes all of those strings. * Fix the MP lobby reloaded indicator always saying the game isn't reloaded. Currently, the value of `game["savegame"]` is one of `mp_game_settings::SAVED_GAME_MODE`. However, the `to_bool()` function doesn't recognize any of those values as being true, so a game is always shown in the MP lobby as not being a reload, even if it actually is. * Revert to default PR trigger types This allows them to trigger when synchronized and reopened too. * Help for the ^Uf mushrooms terrains, including an editor-only hint As the terrain is hidden in help, these hints can only be seen by using the "Terrain Description" command on a ^Uf or ^Ufi mushroom hex, and then switching to the overlay's own page. A hint for players about how these mushrooms behave, and an editor-only hint about replacing the ^Uf mushroom terrains with ^Tf. * Allow translatable strings to display carets to the user (wesnoth#4359) Treat "editor^The overlays '^Uf' and '^Ufi' are deprecated because ..." as a having translation hint "editor", and show "The overlays ..." to the user. This disallows using carets inside the translation hint itself. Code already reviewed in the discussion in wesnoth#4359. * Changelog for wesnoth#4359
Commit 2b65a8c changed the meaning of abilities'
affect_allies
attribute, this issue is to work out what should be done with theaffect_allies
andaffect_enemies
attributes.Before then, affect_allies was a tristate rather than a boolean before that change: it has a different meaning if it's unset vs "yes" or "no". The value determines both whether the ability affects units on the same side, and units on allied sides, as shown the diff of affects_side:
2b65a8c#diff-b1309a16dace4f5829b1ccb49d1d2ce5
The text was updated successfully, but these errors were encountered: