Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wesnothd] better error handling for mp_mod_group setting #4266

Closed
soliton- opened this issue Aug 22, 2019 · 0 comments · Fixed by #4270
Closed

[wesnothd] better error handling for mp_mod_group setting #4266

soliton- opened this issue Aug 22, 2019 · 0 comments · Fixed by #4270
Labels
Enhancement Issues that are requests for new features or changes to existing ones. MP Issues with multiplayer support or bundled multiplayer content.

Comments

@soliton-
Copy link
Member

When the [user_handler] mp_mod_group setting is empty or doesn't contain a valid number wesnothd just terminates with:

error server: terminated by C++ exception: stoi

Would be nice if that would produce a more descriptive error message. Terminating is still okay unless the key was not in the config at all. I'd say if the key is not there, empty or 0 that should deactivate the group check.

@Wedge009 Wedge009 added Enhancement Issues that are requests for new features or changes to existing ones. MP Issues with multiplayer support or bundled multiplayer content. labels Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Issues that are requests for new features or changes to existing ones. MP Issues with multiplayer support or bundled multiplayer content.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants