Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttT: Delfador's portrait faces left #4345

Closed
jostephd opened this issue Sep 14, 2019 · 7 comments
Closed

HttT: Delfador's portrait faces left #4345

jostephd opened this issue Sep 14, 2019 · 7 comments
Labels
Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Enhancement Issues that are requests for new features or changes to existing ones. Good first issue Issues deemed adequate for contributors without prior experience to work on. Graphics Issues that involve the graphics engine or assets. Low Priority Issues that will cause no meaningful problems if left unaddressed.

Comments

@jostephd
Copy link
Member

Delfador's portraits faces left:

https://github.com/wesnoth/wesnoth/blob/1.14/data/campaigns/Heir_To_The_Throne/images/portraits/delfador.png
https://github.com/wesnoth/wesnoth/blob/1.14/data/campaigns/Heir_To_The_Throne/images/portraits/delfador-elvish.png

Portraits generally face right or forward. Delfador's portrait should either be flipped or be shown on the right, like Arvith's portrait in AOI.

@jostephd jostephd added Enhancement Issues that are requests for new features or changes to existing ones. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Graphics Issues that involve the graphics engine or assets. Low Priority Issues that will cause no meaningful problems if left unaddressed. labels Sep 14, 2019
@Earth-Cake
Copy link
Contributor

Earth-Cake commented Sep 14, 2019

Showing him on right would be much easier, because if you rotate him the shading should be changed as well.

@jostephd jostephd added the Good first issue Issues deemed adequate for contributors without prior experience to work on. label Sep 15, 2019
@Wedge009
Copy link
Member

Just wondering, is there a specific reason for the convention that portraits face right vs left? (The placement of the portrait in dialogue?)

@GregoryLundberg
Copy link
Contributor

I like the portaits the turn toward the center, yes. If two alternate, it's like they're talking to each other. Flipping usually won't work because, then, the shadows and highlights flip sides. This is especially true if one character is usually on the left but is on the right once or twice, in reply to another.

@jostephd
Copy link
Member Author

Further complication here:

https://github.com/wesnoth/wesnoth/blob/1.14/data/campaigns/Heir_To_The_Throne/images/portraits/delfador.png faces left
https://github.com/wesnoth/wesnoth/blob/1.14/data/campaigns/Heir_To_The_Throne/images/portraits/delfador-mentoring.png faces right
https://github.com/wesnoth/wesnoth/blob/1.14/data/campaigns/Heir_To_The_Throne/images/portraits/delfador-mad.png faces forward

(The -elvish portraits are the same)

We probably don't want Delfador's portrait to be shown on the right when he's mentoring and on the left normally, so I guess we need new art here? Unless these specific images happen to look good even flipped.

Also, looking at the portrait I'm not sure what Delfador's dominant hand is. -mentoring and -mad show him holding the book and the staff in the same hand, but I'd expect him to hold the staff in his dominant hand and the book in his non-dominant hand?

@Wedge009
Copy link
Member

Watching my brother replay the tutorial in 1.15.1 (just for fun, he's coming back after not having played since 1.12) I saw that Delfador's portrait was on the right, probably for the reasons discussed above. Is there an inconsistency to how Delfador's portraits are oriented throughout the campaigns?

And yeah, that's a bit bothersome that mentoring is the odd one out. Do we have the artist available to consult on this? eg Can we simply mirror that one or would that change the artistic intention (while people are generally symmetrical, asymmetry is inherent in all of us)?

@Wedge009
Copy link
Member

I updated all the left-facing Delfador images I could find, both in HttT and DM, to be displayed on the right side of the dialogue. Basically default Delfador and Delfador-in-elvish-dress in HttT and 'young' and 'old' (but not 'younger') versions of Delfador in DM. Delfador in the Tutorial is already displayed on the right.

Please re-open if I've missed anything. I didn't check if there are other left-facing portraits in other campaigns.

@jostephd
Copy link
Member Author

Thanks!

Wedge009 added a commit that referenced this issue Oct 25, 2019
Some of Delfador's portraits face to the left. A cosmetic change only, but we prefer to such portraits to be displayed to the right of the dialogue so that they face the 'middle'. It also gives impression of a conversation with a right-facing portrait displayed (by default) on the left.

Resolves #4345.

[ci skip]

(cherry picked from commit d29e73e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Enhancement Issues that are requests for new features or changes to existing ones. Good first issue Issues deemed adequate for contributors without prior experience to work on. Graphics Issues that involve the graphics engine or assets. Low Priority Issues that will cause no meaningful problems if left unaddressed.
Projects
None yet
Development

No branches or pull requests

4 participants