Recruit list shows experience in blue

[IskarJarak]

Game and System Information

• 1.15.2
• website download
• Windows 10

Describe the bug

Unit that cannot further advance (e.g., Gryphon Master, Lancer, etc.) show experience bar in blue in the recruit menu.

To Reproduce

Found in NR, tested for various factions in arbitrary Era of Heroes maps. So far as I can tell the issue is global.

Expected behavior

Exp bar should be violet to show that now further advancements are possible. (Same as in recall, etc.)

Screenshots

[github-actions]

Hi! Thanks for helping make Wesnoth even better!

[Wedge009]

I can't recall any particular scenario where you are permitted to recruit such advanced units straight away - can you give some examples for testing?

[IskarJarak]

Hey, for testing I'd advise to start a multiplayer game with Era of Heroes (Multiplayer -> local game -> choose Era of Heroes on the right side, select any map, start the match), then you can recruit all level 2 units of your faction (e.g., Loyalists have Lancer and Javelineer which can't advance).
Otherwise, I met the problem in Northern Rebirth - I think you can only recruit non-advanceable level 2 units (Gryphons) in the last one or two scenarios though (depending on branch).

[Wedge009]

My guess is that since this situation of having fully-advanced units available for recruiting is so rare, it's easy to see how this one got missed. It could also be a deliberate decision, though I don't see a reason for it to be.

Anyway, confirmed on master and 1.14, with the penultimate scenario for Northern Rebirth, 'Get the Gold'.

[Wedge009]

If I've found the right place I think the issue is here:

wesnoth/src/gui/widgets/unit_preview_pane.cpp

Lines 343 to 357 in 396b258

	{ "hp",{
	{ "label", (formatter() << "<small>" << "<span color='#21e100'>" << "<b>" << _("HP: ") << "</b>" << type.hitpoints() << "</span>" << " | </small>").str() },
	{ "use_markup", "true" },
	{ "tooltip", get_hp_tooltip(type.movement_type().get_resistances().damage_table(), [&type](const std::string& dt, bool is_attacker) { return type.resistance_against(dt, is_attacker); }) }
	} },
	{ "xp",{
	{ "label", (formatter() << "<small>" << "<span color='#00a0e1'>" << "<b>" << _("XP: ") << "</b>" << type.experience_needed() << "</span>" << " | </small>").str() },
	{ "use_markup", "true" },
	{ "tooltip", (formatter() << _("Experience Modifier: ") << unit_experience_accelerator::get_acceleration() << '%').str() }
	} },
	{ "mp",{
	{ "label", (formatter() << "<small>" << "<b>" << _("MP: ") << "</b>" << type.movement() << "</small>").str() },
	{ "use_markup", "true" },
	{ "tooltip", get_mp_tooltip(type.movement(), [&type](t_translation::terrain_code terrain) { return type.movement_type().movement_cost(terrain); }) }
	} },

The problem is that in this particular spot we're looking at generic unit types, not a specific unit. Otherwise we can use unit::xp_color() as we do in most other places:

wesnoth/src/gui/widgets/unit_preview_pane.cpp

Lines 503 to 517 in 396b258

	{ "hp",{
	{ "label", (formatter() << "<small>" << font::span_color(u.hp_color()) << "<b>" << _("HP: ") << "</b>" << u.hitpoints() << "/" << u.max_hitpoints() << "</span>" << " | </small>").str() },
	{ "use_markup", "true" },
	{ "tooltip", get_hp_tooltip(u.get_base_resistances(), [&u](const std::string& dt, bool is_attacker) { return u.resistance_against(dt, is_attacker, u.get_location()); }) }
	} },
	{ "xp",{
	{ "label", (formatter() << "<small>" << font::span_color(u.xp_color()) << "<b>" << _("XP: ") << "</b>" << unit_xp << "</span>" << " | </small>").str() },
	{ "use_markup", "true" },
	{ "tooltip", (formatter() << _("Experience Modifier: ") << unit_experience_accelerator::get_acceleration() << '%').str() }
	} },
	{ "mp",{
	{ "label", (formatter() << "<small>" << "<b>" << _("MP: ") << "</b>" << u.movement_left() << "/" << u.total_movement() << "</small>").str() },
	{ "use_markup", "true" },
	{ "tooltip", get_mp_tooltip(u.total_movement(), [&u](t_translation::terrain_code terrain) { return u.movement_cost(terrain); }) }
	} },

Since the colours are hard-coded at the moment (not a great situation to begin with), the unit type display would need to know if a given unit type is the max level for that line of units and then change the colour of the display accordingly. Is there a method to determine if a given unit type is the last in its line?