Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.15] experimental_ai only available in debug mode #4997

Closed
sevu opened this issue Jul 16, 2020 · 3 comments
Closed

[1.15] experimental_ai only available in debug mode #4997

sevu opened this issue Jul 16, 2020 · 3 comments
Assignees
Labels
AI Issues with the AI engine, including micro AIs. Bug Issues involving unexpected behavior.

Comments

@sevu
Copy link
Member

sevu commented Jul 16, 2020

An unintended side effect of hiding it, all sides with [side][ai]ai_algorithm=experimental_ai have effectively no AI unless started with -d.

I also think it doesn't need to be hidden. It has still the different recruiting where it differs from the standard AI, which is a big feature.

This bug was found by @knyghtmare playing a campaign on 1.15, the one I used to test the experimental_ai last year.

@sevu sevu added Bug Issues involving unexpected behavior. AI Issues with the AI engine, including micro AIs. Blocker: Point Issues that render components effectively unusable and must be fixed before the next point release. labels Jul 16, 2020
@mattsc
Copy link
Member

mattsc commented Jul 17, 2020

I'm not sure whether I agree that this is a bug and a blocker. If you set the AI algorithm to a "non-existing" AI, that's no surprise that it won't work.

Having said that, I do agree that having the ExpAI hidden does not make much sense given the current differences. Originally, the new default AI was supposed to be much closer to the ExpAI. I had planned to port the new recruiting algorithm also, and castle switching was removed from default again because it caused more problems than it helped.

Bottom line is: I'll wait a couple days just in case there are objections (I don't expect any) and then I'll make the ExpAI available again without debug mode.

@Pentarctagon Pentarctagon removed the Blocker: Point Issues that render components effectively unusable and must be fixed before the next point release. label Jul 17, 2020
@Pentarctagon
Copy link
Member

I've removed the "Blocker: Point" label since this doesn't cause widespread and gamebreaking issues.

mattsc added a commit that referenced this issue Jul 19, 2020
This reverts 24af20c, which made it available in debug mode only, as there remain more differences to the new default AI than initially envisioned. This takes care of Issue #4997.
@mattsc
Copy link
Member

mattsc commented Jul 19, 2020

Closing via c725376.

@mattsc mattsc closed this as completed Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues with the AI engine, including micro AIs. Bug Issues involving unexpected behavior.
Projects
None yet
Development

No branches or pull requests

3 participants