Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABILITY_TELEPORT causes lots of "terrain.owner is deprecated" warnings #5816

Closed
stevecotton opened this issue May 29, 2021 · 5 comments · Fixed by #5824
Closed

ABILITY_TELEPORT causes lots of "terrain.owner is deprecated" warnings #5816

stevecotton opened this issue May 29, 2021 · 5 comments · Fixed by #5824
Labels
Bug Issues involving unexpected behavior. WFL Issues involving the Wesnoth Formula Language engine and APIs.

Comments

@stevecotton
Copy link
Contributor

Game and System Information

Current master, 1.15.13+dev 4ee5e41

Describe the bug

Units with {ABILITY_TELEPORT} cause lots of warnings about "terrain.owner" and "unit.side" being deprecated.

To Reproduce

  1. Have a Silver Mage on a map with villages
  2. Get the game to calculate where they can move to
@stevecotton stevecotton added Bug Issues involving unexpected behavior. WFL Issues involving the Wesnoth Formula Language engine and APIs. labels May 29, 2021
@stevecotton
Copy link
Contributor Author

This triggers during the AI turn if the side's recruit list includes silver mages; they don't even need to be on the map.

@knyghtmare
Copy link
Member

OH...this explains why I was bombarded by over 12k lines if "Invalid WML found" in WoF S5
WoF-The Three Sisters.gz
Screenshot 2021-05-29 000850
wesnoth-20210528-230410-16948.log

@stevecotton
Copy link
Contributor Author

The reproduction steps are short and quick. I'm disappointed that the issue was closed without checking that the issue was fixed, especially given how quick it was to test.

I think the only other cause is the other formula in ABILITY_TELEPORT, but the reason that I don't just change it and push the one-liner is that fixing an issue should include spending time testing.

@sigurdfdragon
Copy link
Contributor

Can confirm that 04455c0 didn't fix the issue

@newfrenchy83
Copy link
Contributor

@CelticMinstrel has forget owner and side in [target]

CelticMinstrel pushed a commit that referenced this issue May 31, 2021
Fix #5816 issue . 04455c0 commit forget second owner and unit.side in formula.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues involving unexpected behavior. WFL Issues involving the Wesnoth Formula Language engine and APIs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants