Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-ons server keeps undefined properties at their previous value upon update #6284

Closed
vgaming opened this issue Nov 11, 2021 · 1 comment
Closed
Assignees
Labels
Add-ons Issues with the add-ons client and/or server. Bug Issues involving unexpected behavior.

Comments

@vgaming
Copy link
Member

vgaming commented Nov 11, 2021

Game and System Information

  • What version of the game are you running? wesnoth_addon_manager version 170ec9b 2021-09-25
  • Where did you download it from? git clone
  • What OS are you running? ArchLinux

Describe the bug

Context: I have an add-on (Creep_Wars_Dev) that I try to update. It previously had a dependency on pick_advance, and now I want to remove it as it's a built-in wesnoth dependency now.

The bug happens when I update the add-on using wesnoth_addon_manager. I'm using this _server.pbl: https://github.com/vgaming/CreepWars/blob/8a417ccf1ec12e589079845674490165d7ff82f3/Creep_War_Dev/_server.pbl which has no dependencies defined.
When I update my addon, the add-on store says that my addon is accepted. The version is updated accordingly, as seen in the game client. However, the dependency does not get removed and remains to be the old one.

In other words, updating an addon with not-specified dependencies did not cause removal of the dependencies. The only thing that worked was to submit this update: vgaming/CreepWars@1d2358c after which everything worked as expected

Steps To Reproduce

  1. Create a new add-on with a dependency specified
  2. Use wesnoth_addon_manager to publish the addon
  3. Remove the dependency from the add-on
  4. Update the addon
  5. Observe from the game client that the add-on still requires the old dependency

Expected behavior

After publishing an add-on that does not specify any dependencies, dependencies should be removed by the addons server

Screenshots

2021 11 11_18:35:46e

@vgaming vgaming added Bug Issues involving unexpected behavior. Add-ons Issues with the add-ons client and/or server. labels Nov 11, 2021
@irydacea irydacea self-assigned this Nov 11, 2021
irydacea added a commit to irydacea/wesnoth that referenced this issue Nov 12, 2021
@vgaming vgaming changed the title Add-on dependencies are not deleted from the add-ons server Add-ons server keeps undefined properties at their previous value upon update Nov 17, 2021
@soliton-
Copy link
Member

Official add-on server instances have been restarted with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add-ons Issues with the add-ons client and/or server. Bug Issues involving unexpected behavior.
Projects
None yet
Development

No branches or pull requests

3 participants