Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wmllint ignoring magic comment #6514

Closed
MXB2001 opened this issue Feb 12, 2022 · 3 comments
Closed

wmllint ignoring magic comment #6514

MXB2001 opened this issue Feb 12, 2022 · 3 comments
Labels
Bug Issues involving unexpected behavior. WML Tools Issues involving WML maintenance tools.

Comments

@MXB2001
Copy link

MXB2001 commented Feb 12, 2022

Game and System Information

  • What version of the game are you running?
    1.16.2
  • Where did you download it from? (Steam, Mac App Store, our website, built from source, etc.)
    flatpak
  • What OS are you running?
    debian linux

Describe the bug

name_inactive= # wmllint: ignore
does not suppress wmllint adding a _ (translation mark) after the =

To Reproduce

  1. First..
    use that code

  2. Then...
    run wmllint on it

  3. Lastly...
    observe that it adds a _

Expected behavior

wmllint should ignore such lines as it does when not using name_inactive=

Extra info

the magic comment "noconvert" does not work any better...
using the block markcheck off/on DOES work but is not desirable (yes, yes one can use it as a dirty, filthy, unclean hack, I know!)

@knyghtmare knyghtmare added the WML Tools Issues involving WML maintenance tools. label Feb 12, 2022
@cooljeanius
Copy link
Contributor

oh yeah I've noticed this with other wmllint checks, too

@Wedge009 Wedge009 added the Bug Issues involving unexpected behavior. label Feb 15, 2022
@soliton-
Copy link
Member

No idea what's so dirty about using markcheck off compared to other directives. Really though you shouldn't need any wmllint directive since empty strings shouldn't be marked as translatable in the first place. If you use "" that already works.

@soliton-
Copy link
Member

Now just name_inactive= is left alone by wmllint as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues involving unexpected behavior. WML Tools Issues involving WML maintenance tools.
Projects
None yet
Development

No branches or pull requests

5 participants