Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quenoth Fighter unit line multi-attack implementation needs improvement #7447

Closed
abepressman opened this issue Mar 11, 2023 · 10 comments
Closed
Labels
Bug Issues involving unexpected behavior. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Confirmed Issues that have been successfully reproduced by at least one developer. Units Issues that involve unit definitions or their implementation in the engine.

Comments

@abepressman
Copy link

Game and System Information

  • Version: 1.17.13
  • Downloaded from: Steam
  • Build info:
  • OS: Mac OS

Description of the bug

For some reason, the Quenoth Fighter line of units appear to have gained extra attacks that don't do anything. (I don't know what was intended, but at least on the version I'm running, they merely have copies of their attacks that deal less damage)
Screen Shot 2023-03-11 at 6 49 41 AM
Screen Shot 2023-03-11 at 6 49 36 AM

Steps to reproduce the behavior

No response

Expected behavior

No response

Additional context

No response

@abepressman abepressman added the Bug Issues involving unexpected behavior. label Mar 11, 2023
@knyghtmare
Copy link
Member

knyghtmare commented Mar 11, 2023

Apparently, they use different number of "attacks" for each. Meaning, that 9-1 there can hit more than one opponent or the same opponent twice.
However, I see a very bad UX here since nothing of this note has been shown to the player (you).

Actually, it's here but not many would take time to read a unit text:
image

@knyghtmare knyghtmare added the Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign label Mar 11, 2023
@abepressman
Copy link
Author

Apparently, they use different number of "attacks" for each. Meaning, that 9-1 there can hit more than one opponent or the same opponent twice.

SO, this is not at all intuitive or explained. If they make the 9-2 attack, their turn ends. If they make the 9-1 attack first, they can follow it up with the 9-2 attack.

Actually, it's here but not many would take time to read a unit text:

The unit text doesn't explain at all how the ability actually works, and if you're a normal player who always uses the better attack first, you'll likely never figure it out.

@Wedge009 Wedge009 changed the title Quenoth Fighter unit line has pointless duplicate attacks Quenoth Fighter unit line multi-attack implementation needs improvement Mar 11, 2023
@Wedge009
Copy link
Member

Again, the heading was misleading. As best as I can see there are two issues:

  • The reason for the seemingly duplicated attack entries is not clear at first - I take it that either the level 1 fighter can expend both of its attacks on one target, as conventional for most other main-line units, or only attack once and then possibly use its other attack on another target.
  • This brings up the other problem in that the fighter can target one opponent with the single attack and then on the subsequent attack choose the double attack option.

@Wedge009 Wedge009 added Confirmed Issues that have been successfully reproduced by at least one developer. Units Issues that involve unit definitions or their implementation in the engine. labels Mar 11, 2023
@abepressman
Copy link
Author

  • This brings up the other problem in that the fighter can target one opponent with the single attack and then on the subsequent attack choose the double attack option.

I have no idea how it's supposed to be implemented. Since the order of attacks affects the number of attacks, which I assume wasn't intended.

@stevecotton
Copy link
Contributor

Also the bug for UI and gameplay are already opened when it comes to attacks used.

The UI bug is #7367, but I don't see a bug for the gameplay. Where's the bug for a unit with attacks_left=1 still being able to use an attack with attacks_used=2?

@Toranks
Copy link
Contributor

Toranks commented Mar 11, 2023

Where's the bug for a unit with attacks_left=1 still being able to use an attack with attacks_used=2?

This is intended? Should have an additional key to set that possibility to yes/no

@Wedge009
Copy link
Member

So that's what those two reports are about, I didn't know they would impact main-line units. Could this be closed as duplicate then, or treated as a campaign-specific subset?

@CelticMinstrel
Copy link
Member

I think I'd probably say this is something that depends on those but might not be equivalent to them…?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues involving unexpected behavior. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Confirmed Issues that have been successfully reproduced by at least one developer. Units Issues that involve unit definitions or their implementation in the engine.
Projects
None yet
Development

No branches or pull requests

7 participants
@stevecotton @CelticMinstrel @knyghtmare @Wedge009 @abepressman @Toranks and others