Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve apply_to name clash in [resistance] #7703

Open
gfgtdf opened this issue Jun 8, 2023 · 3 comments
Open

Resolve apply_to name clash in [resistance] #7703

gfgtdf opened this issue Jun 8, 2023 · 3 comments
Labels
Enhancement Issues that are requests for new features or changes to existing ones. WML Issues involving the WML engine or WML APIs.

Comments

@gfgtdf
Copy link
Contributor

gfgtdf commented Jun 8, 2023

currently [resistance] has a apply_to=blade/impact... attribute, most other attack related abilities have a apply_to=self/opponent/both attribute, it'd be nice if we could rename [resistance] apply_to= attribute to use apply_to= for apply_to=self/opponent/both like the other abilities to. I'm currently thinking of renaming it do damage_type=blade/impact...

@Pentarctagon
Copy link
Member

This sounds like it could impact a fairly significant number of add-ons.

@Wedge009 Wedge009 added Enhancement Issues that are requests for new features or changes to existing ones. WML Issues involving the WML engine or WML APIs. labels Jun 8, 2023
@stevecotton
Copy link
Contributor

[effect] also has apply_to=, so WML authors will already know that different tags use different lists with the similarly-named attribute.

I'd support printing a warning message if the value contained self/opponent/both, but I'm against renaming the attribute.

@gfgtdf
Copy link
Contributor Author

gfgtdf commented Jun 8, 2023

This sounds like it could impact a fairly significant number of add-ons.

Well, it'd have a compatibility path of course

[effect] also has apply_to=,

Well yes but effects are different things, apply_to is a basic attribute for attack related abilities, and in just one ability it does something completely different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Issues that are requests for new features or changes to existing ones. WML Issues involving the WML engine or WML APIs.
Projects
None yet
Development

No branches or pull requests

4 participants