Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an easy way to re-run the migrator #7936

Closed
cooljeanius opened this issue Oct 2, 2023 · 5 comments · Fixed by #8791
Closed

Provide an easy way to re-run the migrator #7936

cooljeanius opened this issue Oct 2, 2023 · 5 comments · Fixed by #8791
Assignees
@Pentarctagon
Labels
Enhancement Issues that are requests for new features or changes to existing ones. Good first issue Issues deemed adequate for contributors without prior experience to work on. UI User interface issues, including both back-end and front-end issues.

Comments

@cooljeanius
Copy link
Contributor

Describe the desired feature

Split off from #2710. Sometimes the migrator messes up. Or sometimes I'd like to migrate from a different branch than I originally migrated from. Or sometimes I'm still using the branch I migrated from, and just need to migrate from it again. In such cases, it would be helpful to have an easy way to re-run the migrator in-game, to pick up any user data that might have been missed previously.
@cooljeanius cooljeanius added Enhancement Issues that are requests for new features or changes to existing ones. UI User interface issues, including both back-end and front-end issues. labels Oct 2, 2023
@cooljeanius cooljeanius mentioned this issue Oct 2, 2023
Open
@Pentarctagon Pentarctagon mentioned this issue Oct 4, 2023
Open
@cooljeanius cooljeanius added the Good first issue Issues deemed adequate for contributors without prior experience to work on. label Oct 13, 2023
@cooljeanius
Copy link
Contributor Author

User in this thread could have benefitted from such a feature: https://forums.wesnoth.org/viewtopic.php?t=57847

@Pentarctagon
Copy link
Member

I was sort of hoping that someone would pick this up as a good first issue, but yeah maybe it should be a higher priority than that.

@Wedge009
Copy link
Member

How does Wesnoth detect when to run the migrator? Investigating another issue, I experimented with deleting the standard logs directory and this seemed to trigger the migrator dialogue at start-up for me.

@Pentarctagon
Copy link
Member

It runs it when the logs folder is not present.

@Wedge009
Copy link
Member

So whatever in-game trigger we introduce for this would be separate to that. Okay.

@Pentarctagon Pentarctagon self-assigned this Apr 20, 2024
Pentarctagon added a commit to Pentarctagon/wesnoth that referenced this issue Apr 22, 2024
@Pentarctagon
Add a button to the build info dialog to rerun the migrator.
8d25716 
Add-ons: checks for any that exist in the chosen other version but not in the current version.
Preferences: adds attributes that don't exist from the chosen other version's preferences that aren't in the current version's preferences. for attributes that exist in both, use whichever was modified most recently.
Credentials: skip on rerun.

Fixes wesnoth#7936
@Pentarctagon Pentarctagon mentioned this issue Apr 22, 2024
Merged
Pentarctagon added a commit to Pentarctagon/wesnoth that referenced this issue Apr 22, 2024
@Pentarctagon
Add a button to the build info dialog to rerun the migrator.
d2b30c7 
Add-ons: checks for any that exist in the chosen other version but not in the current version.
Preferences: adds attributes that don't exist from the chosen other version's preferences that aren't in the current version's preferences. for attributes that exist in both, use whichever was modified most recently.
Credentials: skip on rerun.

Fixes wesnoth#7936
Pentarctagon added a commit to Pentarctagon/wesnoth that referenced this issue Apr 22, 2024
@Pentarctagon
Add a button to the build info dialog to rerun the migrator.
df0a38b 
Add-ons: checks for any that exist in the chosen other version but not in the current version.
Preferences: adds attributes that don't exist from the chosen other version's preferences that aren't in the current version's preferences. for attributes that exist in both, use whichever was modified most recently.
Credentials: skip on rerun.

Fixes wesnoth#7936
Pentarctagon added a commit to Pentarctagon/wesnoth that referenced this issue Apr 22, 2024
@Pentarctagon
Add a button to the build info dialog to rerun the migrator.
6c5b664 
Add-ons: checks for any that exist in the chosen other version but not in the current version.
Preferences: adds attributes that don't exist from the chosen other version's preferences that aren't in the current version's preferences. for attributes that exist in both, use whichever was modified most recently.
Credentials: skip on rerun.

Fixes wesnoth#7936
Pentarctagon added a commit that referenced this issue Apr 27, 2024
@Pentarctagon
Add a button to the build info dialog to rerun the migrator. (#8791)
b3f6f80 
Add-ons: checks for any that exist in the chosen other version but not in the current version.
Preferences: adds attributes that don't exist from the chosen other version's preferences that aren't in the current version's preferences. for attributes that exist in both, use the attributes from the file that was modified most recently.
Credentials: move if the credentials file doesn't exist.

Fixes #7936
Pentarctagon added a commit that referenced this issue Apr 27, 2024
@Pentarctagon
Add a button to the build info dialog to rerun the migrator. (#8791)
4dfb946 
Add-ons: checks for any that exist in the chosen other version but not in the current version.
Preferences: adds attributes that don't exist from the chosen other version's preferences that aren't in the current version's preferences. for attributes that exist in both, use the attributes from the file that was modified most recently.
Credentials: move if the credentials file doesn't exist.

Fixes #7936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pentarctagon Pentarctagon

Labels
Enhancement Issues that are requests for new features or changes to existing ones. Good first issue Issues deemed adequate for contributors without prior experience to work on. UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a button to the build info dialog to rerun the migrator. Pentarctagon/wesnoth
3 participants
@cooljeanius @Pentarctagon @Wedge009