editor: Save into addon when saving a scenario

[soliton-]

Describe the desired feature

When creating a scenario in the editor it asks for an addon but when then saving the scenario the save dialog starts out at editor/scenarios in userdata and not in the chosen addon.

[babaissarkar]

See if commit 64f136c in #8903 solves this.

[soliton-]

I can't test right now but that looks good.

[soliton-]

I also noticed that even when you save the scenario in editor/scenarios the map file is saved in the addon and the editor can find it again when opening. However that is pretty confusing and the game does not expect that when checking custom scenarios under editor/scenarios. So you can't play the scenario then.

We should probably deprecate editor/scenarios since it's easy now to just make an addon, so it just adds confusion.

[babaissarkar]

I also noticed that even when you save the scenario in editor/scenarios the map file is saved in the addon and the editor can find it again when opening. However that is pretty confusing and the game does not expect that when checking custom scenarios under editor/scenarios. So you can't play the scenario then.

I'll check that.

We should probably deprecate editor/scenarios since it's easy now to just make an addon, so it just adds confusion.

I agree.

[soliton-]

It's actually a bit odd that Save Scenario As saves the map as well.

I think it would make more sense if Save Map (just a button, ctrl+s) gets renamed to Save All or Save Scenario+Map or so and saves both. And then Save Map/Scenario As just save the map and scenario respectively.

[babaissarkar]

I think it would make more sense if Save Map (just a button, ctrl+s) gets renamed to Save All or Save Scenario+Map or so and saves both. And then Save Map/Scenario As just save the map and scenario respectively.

Did that (Renamed to Save). Also, Save Scenario As is now only visible when the user is in Scenario editing mode.