Editor enhancements

[babaissarkar]

Contains various enhancements mostly to the Time Schedule Editor that I couldn't manage to add in #8066. It also contains a few other things in the Map Editor itself. There are also changes to the Unit Type Editor that are related to the new features in the Schedule Editor.

Map Editor

• Rename Load Map to Load Map/Scenario (since it can load both), Edit Scenario to Edit Scenario Settings, Save Map to just Save.
• Rearrange menu order
• Add icon for the preferences menu item (used the preexisting settings.png icon)
• Open folder correctly at Add-on's scenario directory instead of editor/scenarios. (Resolves editor: Save into addon when saving a scenario #8910)
• Show Save Scenario As only for Scenarios
• Use the settings.png icon for Preferences menu item
• Add functionality to "Loyal" checkbox (Unit tool -> Place unit -> Right click menu) (Resolves Loyal Units in Editor Tool #8445)
• Do not allow maps to be saved in scenarios folder or vice versa
  Map Mode:
  

Scenario Mode:

Time Schedule Editor

• Browse buttons now set wesnoth style paths instead of just pasting the absolute path returned by the file dialog
• Change text boxes from inactive to uneditable.
• Code generation improvements
• Add copyright notice to tod_new_schedule (missed in Add functionality to Time Schedule Editor #8066)
• Confirmation messages
• New icons for the preview button (2 sets : preview image and preview sound)
• Preview buttons for image and sound files
  

Unit Type Editor

The last four entries above :

• Confirmation messages
• New icons for the preview button (2 sets : preview image and preview sound)

Add-on menu

• Two new items for (1) opening the select add-on dialog, (2) opening the add-on folder
  

The open add-on folder option shows a GUI2 file dialog at the add-on's folder which can be used to open any file. If it is a loadable map/scenario it will be opened in the editor, otherwise the OS's default application for that file will be opened.

File Dialog

• Redesigned with new icons
• New Open External button that opens selected file/folder in the platform's default application (independently of what pressing Open would do). This could be used to quickly open a folder or preview the file before actually selecting it.
• Extension checking and filename validation. (See editor: Pick proper dir and filename in Save Map/Scenario As dialog #8911 (comment))

[CelticMinstrel]

• Rename Load Game to Load Game/Scenario (since it can load both)

I'm not sure how you got this wrong, but it's Map, not Game.

[babaissarkar]

What do you mean by "prefix"? It converts an absolute path to something like "misc/some-image.png" (the same as what is supported by image widget's label)

…

On Wed 22 May, 2024, 7:11 PM Celtic Minstrel, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/gui/dialogs/editor/custom_tod.cpp <#8903 (comment)>: > + std::string rel_path = ""; + std::string core_asset_dir = filesystem::get_dir(game_config::path + "/data/core/" + asset_type); + std::string addon_asset_dir; + + bool is_in_core_dir = (abs_path.find(core_asset_dir) != std::string::npos); + bool is_in_addon_dir = false; + + if (!addon_id_.empty()) { + addon_asset_dir = filesystem::get_current_editor_dir(addon_id_) + "/" + asset_type; + is_in_addon_dir = (abs_path.find(addon_asset_dir) != std::string::npos); + } + + if (is_in_core_dir) { + rel_path = abs_path.erase(0, core_asset_dir.size()+1); + } else if (is_in_addon_dir) { + rel_path = abs_path.erase(0, addon_asset_dir.size()+1); …doesn't this need to add a prefix to the path as well? — Reply to this email directly, view it on GitHub <#8903 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACAT3AEX3DAEJ2W7VNCOPKDZDSN7XAVCNFSM6AAAAABIC2EFUWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZRGI2TIOJVGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[CelticMinstrel]

Hmm, I think I'm getting confused between asset paths and WML paths actually. Never mind.