fix default login on windows #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| std::string login() | ||
| { | ||
| const std::string res = preferences::get("login"); | ||
| if(res.empty() || res == EMPTY_WRAPPED_STRING) { | ||
| char* const login = getenv("USER"); | ||
| if(login != NULL) { | ||
| std::string login = get_system_username(); |
There was a problem hiding this comment.
login could benefit from becoming a const reference, since it previously was a const pointer.
|
Is there a particular reason some of the newly introduced code breaks our de facto convention of keeping the opening brace for an if body on the same line as the end of the conditional expression? |
getenv("USER") doesn't work on windows. Also winapifunctions use utf16
strings.
|
pushed another version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getenv("USER") doesn't work on windows. Also winapifunctions use utf16 strings.