don't limit server max sides #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are 2 reasons why the maximum side number is limited in some contexts: 1) The map format can only store 9 starting positions 2) only the first 9 sides have default colors. However, 'color' and 'starting position' are both sideproperties that can explicitly given by wml if needed. And the server doesn't use any of them, so i see no reason why the server should reject those games.
i actualy didnt test whether this casues bugs. But we use color to set the value of combo_color_ combobox which has only MAX_PLAYER number of options.
gfgtdf
force-pushed
the
wesnothd_sides
branch
from
7127954
to
a53594b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are 2 reasons why the maximum side number is limited in some
contexts:
However, 'color' and 'starting position' are both sideproperties that
can explicitly given by wml if needed. And the server doesn't use any of
them, so i see no reason why the server should reject them.