make force_lock_settings default to true for [scenario] #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most cases the campaigns designer don't want the use to be able to overwrite scenario properites like "turn limit" or "use fog". It is easiert to do this here in the code that loads the config than in the code that reads that value becasue there are multiple codes that read it and it's not clear that all of then know whether teh scenario was a [multiplayer] or a [scenario]. Partly implements http://gna.org/bugs/?23037 which suggests to remove the ability to overwite those settings in capaigns completely.
gfgtdf
force-pushed
the
lock_settings
branch
from
eb33923
to
213c829
Compare
gfgtdf
added a commit
that referenced
this pull request
Dec 19, 2014
make force_lock_settings default to true for [scenario]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases the campaigns designer don't want the use to be able to
overwrite scenario properites like "turn limit" or "use fog".
It is easiert to do this here in the code that loads the config than in
the code that reads that value becasue there are multiple codes that
read it and it's not clear that all of then know whether teh scenario
was a [multiplayer] or a [scenario].
Partly implements http://gna.org/bugs/?23037 which suggests to remove
the ability to overwite those settings in capaigns completely.