Fixup sliders 1.12 #377
Merged
Fixup sliders 1.12 #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit causes sliders to attract focus properly when their grips are clicked on, and to respond to left and right arrow presses again. It partly reverts two earlier commits that affected this functionality. cf84e1d 4961459 It causes the zoom slider to behave slightly badly, because it does not lose focus when the user clicks elsewhere on the map. But this bug should be fixed at the source and not by disabling wanted functionality for all sliders. Conflicts: src/widgets/slider.cpp
When the slider widget was added to ThemeWML, some work was not done apparently to make it play nicely with regards to focus and key events with the other theme wml widgets, causing it to retain focus for keyboard events indefinitely. At the time this was resolved by disabling these events, but this cripples the many other sliders in the game. In this commit we introduce a subclass zoom_slider which has this functionality disabled, and use that for zoom sliders, so that we can get the desired functionality back for the other sliders. See parent of this commit for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #376