Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DiD] S7-S9 revisions #3860

Merged
merged 29 commits into from
Mar 2, 2019
Merged

[DiD] S7-S9 revisions #3860

merged 29 commits into from
Mar 2, 2019

Conversation

nemaara
Copy link
Contributor

@nemaara nemaara commented Jan 10, 2019

As the title states, updates the dialogue in DiD S7.

@nemaara
Copy link
Contributor Author

nemaara commented Jan 11, 2019

After some discussion with josteph, I've decided I'll be updating the gameplay for S7 and S8 simultaneously (they will depend on each other). So, this PR will no longer only be a dialogue revision; there will be gameplay changes in it as well.

@nemaara nemaara changed the title [DiD] Added dialogue to S7 [DiD] S7 and S8 revisions Jan 11, 2019
@sevu sevu added this to the 1.14.7 milestone Jan 12, 2019
@jostephd jostephd added the In-progress Issues for which a fix is currently being worked on. label Jan 12, 2019
@jostephd
Copy link
Member

Labeled "in progress" until the S8 changes are pushed for review.

@jostephd jostephd added this to Issues in DiD revision 2019 Jan 12, 2019
@jostephd
Copy link
Member

This PR will revert ab16924. Please rebase this PR so it doesn't revert other people's work. Please check that none of the other DiD PRs have this problem either.

@nemaara
Copy link
Contributor Author

nemaara commented Jan 13, 2019

Sorry. D:

Should be fixed now, I'll double check the others.

@jostephd jostephd removed the In-progress Issues for which a fix is currently being worked on. label Jan 14, 2019
@nemaara
Copy link
Contributor Author

nemaara commented Jan 15, 2019

I've playtested both scenarios. They're meant to be balanced around getting 5-7 level 3 units (ghosts are best) and seem to be of reasonable difficulty with an army like that. I can provide a save if anyone else wants to playtest as well.

@jostephd
Copy link
Member

How much gold+carryover is the player expected to start with?

@nemaara
Copy link
Contributor Author

nemaara commented Jan 15, 2019

I assumed base gold, 120, which gives you 6 recalls. Some minor carryover will get you to 7; I passed on 5 without too much trouble. If you have more carryover, these scenarios will be easier, but I don't think it's a good idea to assume people will have any.

@nemaara nemaara changed the title [DiD] S7 and S8 revisions [DiD] S7-S9 revisions Jan 15, 2019
@nemaara
Copy link
Contributor Author

nemaara commented Jan 15, 2019

Now includes S9 because balancing will depend heavily on the previous two scenarios.

@nemaara nemaara merged commit a2e459f into wesnoth:master Mar 2, 2019
@nemaara nemaara moved this from Issues to Completed in DiD revision 2019 Mar 2, 2019
@nemaara nemaara moved this from Completed to Issues in DiD revision 2019 Mar 2, 2019
@nemaara nemaara moved this from Issues to Completed in DiD revision 2019 Mar 2, 2019
@@ -451,7 +451,7 @@

[message]
speaker=Darken Volk
message= _ "The stolen book lies within Lord Karres’s manor at the north end of the city. It will be difficulty for us to defeat the entire city guard, so we must stay hidden as long as possible. For now, we can use this fog to our advantage. I will cast a spell using it to obscure the vision of the town guards. It should not affect us, however."
message= _ "The stolen book lies within Lord Karres’s manor at the north end of the city. It will be difficult for us to defeat the entire city guard, so we must stay hidden as long as possible. For now, we can use this fog to our advantage. I shall use it to cast a spell to obscure town guards’ vision. It should not affect us, however."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "the" after "obscure".

@nemaara nemaara deleted the DiD_S7_dialogue branch April 16, 2019 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants