[Tutorial] Small fixes #3963
[Tutorial] Small fixes #3963
Conversation
|
You should really merge 6f23fc1 and 3777569 into a single commit, since the former references the unit added by the latter. Could also merge ecb0f1a in with it, but that's not so important (even though it makes no sense to commit it before actually adding the new unit, at least it's not directly referencing anything in the other commits). That aside, this looks good! |
|
(Oh right, also... shouldn't that changelog entry be in 1.14.7+dev, not 1.14.6+dev?) |
|
Maybe I'm not understanding what the headings mean, but for example when I did the TSG revision, the changelog entry was under 1.14.5+dev (but the TSG revision went in 1.14.6). Since this is going in 1.14.7, I thought that the changelog entry should be in 1.14.6+dev similarly? |
|
Ah, sorry, you're right. I got confused there about the changelog headers. (By the way, not related, but why is 1.14.5+dev not changed to 1.14.6 yet?) |
It is on the 1.14 branch but not on master. |
| @@ -125,6 +125,11 @@ | |||
| * S17c: Modified Burin's description of trolls | |||
| * The South Guard: | |||
| * Fixed various typos | |||
| * Tutorial: | |||
| * Remove swamp from map for part 2 | |||
There was a problem hiding this comment.
Why remove the swamp hexes? Couldn't we just add an event for them? The tutorial is basically an interactive trailer, I think it is good to have it show off a bit of terrain variety.
There was a problem hiding this comment.
There are literally just a couple swamp hexes laying around that look pretty ugly anyway. If we wanted to show off terrain variety, it would involve redrawing the map, not having those hexes.
|
For the record, I don't really care one way or another about the swamp hexes. |
For #3390, see my comment there (#3390 (comment)).