Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new stone wall terrain variation -> catacombs #4527

Merged
merged 5 commits into from Nov 10, 2019

Conversation

doofus-01
Copy link
Member

A modified stone wall, goal is to have overlays, animations, or something to make this useful for undead scenarios, but for now it's just the base terrain graphics images.
catacombs1

@doofus-01 doofus-01 added Graphics Issues that involve the graphics engine or assets. Terrain Issues that involve terrain definitions or their implementation in the engine. labels Oct 28, 2019
@stevecotton
Copy link
Contributor

I suggest making a terrain code that does not have the stone2 variation, for ancient catacombs where any cloth that was there has already rotted away.

Xot^Efs has the sconce over the opening - would it be simple to move the sconce along the wall a bit for that terrain combination?

@CelticMinstrel
Copy link
Member

Does this meld nicely with the regular wall if you want the niches to be more spaced out?

@doofus-01
Copy link
Member Author

I suggest making a terrain code that does not have the stone2 variation, for ancient catacombs where any cloth that was there has already rotted away.

I made the cloth less "puffy", I think it's more subtle now, could be very old and rotted away.

Xot^Efs has the sconce over the opening - would it be simple to move the sconce along the wall a bit for that terrain combination?

I think it's better to have a variation, changing the position has potential for headaches (Xos^Efs and Xot^Efs next to each other, for example)

Does this meld nicely with the regular wall if you want the niches to be more spaced out?

Possibly, depending on what you are expecting. Since the wall panels and hexes don't line up, I'm not sure it's possible to make every other one have a hole, at least not in a way the user can control.
Screenshot_20191101

@doofus-01
Copy link
Member Author

Last commit isn't specific to catacombs, but it gets closer to what I think @CelticMinstrel was asking about. Minor variations means Xom/Xoi can mix, and Xos/Xoc/Xot can mix, where 'mix' means every other SE/SW facing panel is alternated.
Screenshot_20191101_b

@doofus-01
Copy link
Member Author

That last commit allows putting bodies in the large diagonal catacombs holes by using the ^Edb overlay, rather than making a new terrain.
Screenshot_20191110_
Doing all this is starting to touch existing terrain graphics too much, I'd like to commit this before adding anything more.

@doofus-01 doofus-01 changed the title [WIP] new stone wall terrain variation -> catacombs new stone wall terrain variation -> catacombs Nov 10, 2019
@stevecotton
Copy link
Contributor

Doing all this is starting to touch existing terrain graphics too much, I'd like to commit this before adding anything more.

Yes, please do.

@doofus-01 doofus-01 merged commit 98b97ed into wesnoth:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graphics Issues that involve the graphics engine or assets. Terrain Issues that involve terrain definitions or their implementation in the engine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants