Title screen: move language button to icon #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemaara
added
the
UI
|
I don't really like using a globe for language, but I suppose it's not the worst option either. |
|
I don't think I'd be able to tell that that button changed language just from that symbol. |
|
The globe icon is a pretty standard language icon. |
|
I don't think it's a very good standard though. It doesn't represent the concept of "language" well. It's far better than using flags though, so I can live with it. |
nemaara
force-pushed
the
language_icon
branch
from
f1e8b2e
to
acc96b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4531. There's not much of a reason to have a big language button. @shikadiqueen suggested making it a globe icon in the lower right, so that's what this is for. Screenshot: