Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding resistance_anim to shema validation #4617

Open
wants to merge 7 commits into
base: master
from

Conversation

@newfrenchy83
Copy link
Contributor

newfrenchy83 commented Dec 2, 2019

If a day, a resistance abilities applied to adjacent unit is added in the core, with a proper animation, it can be validated.

newfrenchy83 added 3 commits Dec 2, 2019
If a day, a resistance abilities applied to adjacent unit is added in the core, with a proper animation, it can be validated.
@CelticMinstrel

This comment has been minimized.

Copy link
Member

CelticMinstrel commented Dec 3, 2019

Um, excuse me? What are you doing renaming an existing animation without any sort of backwards compatibility? If it was just the first commit I would've merged it immediately, but the second two commits are all sorts of questionable.

@newfrenchy83

This comment has been minimized.

Copy link
Contributor Author

newfrenchy83 commented Dec 3, 2019

@CelticMinstrel after the first commit the travis checking failing because apply_to=(blade,pierce,tec) key became invalid. If necessary what animation name different what name of ability who call this animation for what shema validation valid.

@CelticMinstrel

This comment has been minimized.

Copy link
Member

CelticMinstrel commented Dec 3, 2019

That doesn't even make sense...

@newfrenchy83

This comment has been minimized.

Copy link
Contributor Author

newfrenchy83 commented Dec 3, 2019

@CelticMinstrel look at this https://travis-ci.com/wesnoth/wesnoth/jobs/262322472#L5140
"20191202 19:43:27 error validation: Invalid key 'impact=' in tag [resistance]" after the first commit, after that, i had the choice to close this PR or change the name of animation

@CelticMinstrel

This comment has been minimized.

Copy link
Member

CelticMinstrel commented Dec 3, 2019

Ah, I see the issue. The existing support for the resistance animation is [animation]apply_to=resistance, right? And you want to be able to shorten it to [resist_anim]. But… was the engine already trying to load the [resistance] tag as an animation? That seems like quite a large oversight…

@newfrenchy83

This comment has been minimized.

Copy link
Contributor Author

newfrenchy83 commented Dec 3, 2019

the engine

Ah, I see the issue. The existing support for the resistance animation is [animation]apply_to=resistance, right? And you want to be able to shorten it to [resist_anim]. But… was the engine already trying to load the [resistance] tag as an animation? That seems like quite a large oversight…

Like leading_anim for [leadership] [resistance] tags for animation already exist in engine for resistance ability, but has never used in core, or elsewhere in my knowledge.

@Wedge009 Wedge009 added the Schema label Dec 4, 2019
@newfrenchy83 newfrenchy83 changed the title add resistance anim to shema validation rename resistance animation and adding to shema validation Dec 16, 2019
@newfrenchy83 newfrenchy83 changed the title rename resistance animation and adding to shema validation adding resistance_anim to shema validation Jan 16, 2020
@newfrenchy83 newfrenchy83 requested a review from CelticMinstrel Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.