WIP fix crash when reading chinese -po files #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfgtdf
changed the title
Wedge009
added
Engine
You may _never_ use the std:: file io functions in wesnoth since they only support acii characters on windows in filenames. We have fixed this many times already but apparently the person that added .po file support wasn't aware of this issue. fixes wesnoth#4965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you may never use the std:: file io functions
in wesnoth since they only support acii characters.
wes have fixed this mayn times already but apparently
the preson that added -po file support didn't knew
that.