Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initiative don't affect allied side in Httt #5218

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Fix initiative don't affect allied side in Httt #5218

merged 1 commit into from
Oct 19, 2020

Conversation

newfrenchy83
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign label Oct 19, 2020
@soliton-
Copy link
Member

Is the idea that the description mentions "friendly units" and that should mean allies are included?

@newfrenchy83
Copy link
Contributor Author

@soliton- yes, in 1.14 macro we have [filter_side]
[allied_with]
[has_unit]
id="Li'sar"
[/has_unit]
[/allied_with]
[/filter_side]

initiative must affect all allies of Li'sar and not only her own side, but i forget to put affect_allies=yes in 1.15

@soliton-
Copy link
Member

Ah, a regression from 1.14.

@soliton- soliton- merged commit 62afd8b into wesnoth:master Oct 19, 2020
@newfrenchy83 newfrenchy83 deleted the patch-12 branch October 19, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@newfrenchy83 @soliton-