Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[harm_unit] fix secondary_attack animation #5369

Merged
merged 1 commit into from Jun 28, 2022
Merged

[harm_unit] fix secondary_attack animation #5369

merged 1 commit into from Jun 28, 2022

Conversation

virtualghetto
Copy link

@github-actions github-actions bot added the Lua API Issues with the Lua engine and API. label Dec 18, 2020
@CelticMinstrel
Copy link
Member

Yeah… this seems fine. It's not my preferred fix, but if it works, it works, I guess…

@virtualghetto virtualghetto deleted the harm_unit branch February 21, 2021 07:01
@virtualghetto virtualghetto restored the harm_unit branch February 21, 2021 07:11
@virtualghetto
Copy link
Author

Oops, closed this by mistake :/

@virtualghetto virtualghetto reopened this Feb 21, 2021
@Pentarctagon
Copy link
Member

@CelticMinstrel What would be the preferred fix?

@CelticMinstrel
Copy link
Member

I would prefer to update it to directly use the wesnoth.create_animator API instead of calling it indirectly via another WML tag.

@Pentarctagon
Copy link
Member

@CelticMinstrel should this be merged or closed?

@CelticMinstrel
Copy link
Member

I think fixing the bug takes priority over doing it properly? We can rewrite it to use create_animator at some later time.

@CelticMinstrel CelticMinstrel merged commit 8d91bc6 into wesnoth:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CelticMinstrel CelticMinstrel Awaiting requested review from CelticMinstrel

Assignees
No one assigned
Labels
Lua API Issues with the Lua engine and API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@virtualghetto @CelticMinstrel @Pentarctagon