Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add items from Blarumyrran and run woptipng on the directory #5821

Merged
merged 1 commit into from
May 30, 2021

Conversation

doofus-01
Copy link
Member

No description provided.

@github-actions github-actions bot added the Graphics Issues that involve the graphics engine or assets. label May 30, 2021
@CelticMinstrel
Copy link
Member

Running woptipng in the same commit makes it impossible to tell what's actually new here… maybe it would be better to run woptipng on master, commit that, then add the new icons?

@doofus-01
Copy link
Member Author

You can look at the rich diff.

@CelticMinstrel
Copy link
Member

That really doesn't help. I mean, sure, you can notice the ones that are brand-new and those that have a very obvious change, but clicking "rich diff" on every image is a huge pain and you'll never know whether one of those that doesn't show an obvious difference is an update or a woptipng alteration.

@doofus-01 doofus-01 merged commit f19d4e4 into wesnoth:master May 30, 2021
@soliton-
Copy link
Member

Certainly anyone trying to figure out attribution from this might as well give up. 2 commits would be much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graphics Issues that involve the graphics engine or assets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants