Avoid use of 'cool' and 'guys' (closes #6107) #6108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have left 'guys' in Camerin's lines as it's justifiable in his informal crazy talk - Northern Rebirth is supposed to be rather informal in parts and light-hearted in tone. [ci skip]
Wedge009
added
Campaign (any)
|
I'm not sure if it's your fault or GitHub's, but the issue link in your commit message is broken… it seems to link to your fork instead of the main Wesnoth repo. |
|
Yea, reading them over, the NR ones especially feel too formal to me. Personally I wouldn't make this change, but depends on what your goal is. Edit: just for NR, the other ones are fine. |
|
I think it's GitHub. I haven't done anything differently but I've noticed it's been showing inconsistently recently to me. Edit: It reads as linking to the main wesnoth/wesnoth issue to me. |
|
@nemaara Can you highlight which ones you object to? Is it all of the Northern Rebirth ones? |
nemaara
reviewed
Sep 20, 2021
data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg
Outdated
Show resolved
Hide resolved
data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg
Outdated
Show resolved
Hide resolved
data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg
Outdated
Show resolved
Hide resolved
nemaara
approved these changes
Sep 20, 2021
Asheviere
pushed a commit
to Asheviere/wesnoth
that referenced
this pull request
Feb 18, 2022
Avoid use of 'cool' and 'guys' (closes wesnoth#6107) Have left 'guys' in Camerin's lines as it's justifiable in his informal crazy talk - Northern Rebirth is supposed to be rather informal in parts and light-hearted in tone. [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #6107, have left 'guys' in Camerin's lines alone.