Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force console on Windows when --help is specified #614

Merged
merged 2 commits into from
Mar 3, 2016

Conversation

techtonik
Copy link
Contributor

No description provided.

@irydacea
Copy link
Member

irydacea commented Mar 2, 2016

This is a good change, but is there a particular reason you used or in the code instead of ||? We don't use the alternative plain-language operators in our code base.

@techtonik
Copy link
Contributor Author

In Python pipes are invalid, so I just not used to them.

irydacea added a commit that referenced this pull request Mar 3, 2016
Force console on Windows when --help is specified
@irydacea irydacea merged commit dbebd45 into wesnoth:master Mar 3, 2016
@techtonik techtonik deleted the patch-1 branch March 4, 2016 20:44
@techtonik
Copy link
Contributor Author

Why tests failed?

@irydacea
Copy link
Member

irydacea commented Mar 4, 2016

Only one build failed due to a time-out. It's a quite common occurrence with Travis, so I decided to ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants