Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference SotA in SoF, closes #6151 #6152

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

max-torch
Copy link
Contributor

@max-torch max-torch commented Oct 4, 2021

Add a reference to SotA North Knalga in Sceptre of Fire.

Add a reference to SotA North Knallga in Sceptre of Fire.
@github-actions github-actions bot added the Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign label Oct 4, 2021
@Wedge009 Wedge009 added the Prose Issues with prose text for the game. label Oct 4, 2021
@Wedge009 Wedge009 requested a review from nemaara October 4, 2021 22:25
@stevecotton
Copy link
Contributor

I feel there ought to be a common name and lore for SotA from the non-necromancers' viewpoint, but that depends on a lore description of what non-necromancers know about SotA, and might be very different from the player knowledge of SotA.

For example, it was lead by a necromancer called Ras-Tabahn who announced himself at Carcyn. Ardonna didn't leave witnesses, so her name is probably unknown.

The desecration of Alduin's graveyard and killing of their watchmen has to be known, but is it known that a student at the university did it?

@max-torch
Copy link
Contributor Author

max-torch commented Oct 5, 2021

I feel there ought to be a common name and lore for SotA from the non-necromancers' viewpoint, but that depends on a lore description of what non-necromancers know about SotA, and might be very different from the player knowledge of SotA.

For example, it was lead by a necromancer called Ras-Tabahn who announced himself at Carcyn. Ardonna didn't leave witnesses, so her name is probably unknown.

The desecration of Alduin's graveyard and killing of their watchmen has to be known, but is it known that a student at the university did it?

Wouldn't Ardonna be known by the journal she left behind to be found? Or was it Malin Keshar who finds the journal? Another thing I wonder is if SotA provides any explanation towards the origins of all the other undead on the wesnoth continent like Mal ravanal, and undead during asheviere's time, and beyond (technically asheviere is first in timeline)? They are all disciples that trace themselves to either Ardonna or Ras-Tabahn?

@stevecotton
Copy link
Contributor

I'd expect anyone reading the journal to do so secretly and not spread knowledge from it, lest they themselves are branded a necromancer.

@@ -155,6 +155,14 @@
speaker=Durstorn
message= _ "Good one, let them try to take it! Ha!"
[/message]
[message]
speaker=Noiraran
message= _ "What about that time the mines of North Knalga was invaded by ancient-looking undead liches?"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't was be were here? The word refers to the mines, which is plural.

Copy link
Contributor Author

@max-torch max-torch Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 540a5c1

Fix plural subject-verb agreement.
@nemaara nemaara merged commit e49b5c7 into wesnoth:master Oct 6, 2021
@max-torch max-torch deleted the Reference-SotA-in-SoF branch October 7, 2021 03:57
Wedge009 pushed a commit that referenced this pull request Nov 10, 2021
SoF: Add a reference to SotA North Knalga in Sceptre of Fire. (fix #6151)
(cherry picked from commit e49b5c7)
Asheviere pushed a commit to Asheviere/wesnoth that referenced this pull request Feb 18, 2022
SoF: Add a reference to SotA North Knalga in Sceptre of Fire. (fix wesnoth#6151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Prose Issues with prose text for the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants