Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WC] [1.17] Three New factions to complete WC era. #6239

Merged
merged 14 commits into from
Oct 31, 2021

Conversation

knyghtmare
Copy link
Member

@knyghtmare knyghtmare commented Oct 29, 2021

Will Fix #6175

Currently

  • The Artisans - Dunefolk+Dwarves
  • The Marauders - Dunefolk+Northerners
  • The Defiance - Dunefolk+Undead

I am still open to name changes or pairing changes or any other suggestions.

Will be merging this within 36 hours if no complaints/remarks.

@github-actions github-actions bot added the Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign label Oct 29, 2021
@knyghtmare knyghtmare added Enhancement Issues that are requests for new features or changes to existing ones. MP Issues with multiplayer support or bundled multiplayer content. labels Oct 29, 2021
@knyghtmare knyghtmare self-assigned this Oct 29, 2021
@knyghtmare
Copy link
Member Author

Hmm, okay...maybe the merger can wait...some pairings are behaving odd. Will investigate.

@knyghtmare
Copy link
Member Author

Hmm, okay...maybe the merger can wait...some pairings are behaving odd. Will investigate.

Okay, no bugs but the recruit lists are appearing odd for marauders and defiance for some reason

@knyghtmare
Copy link
Member Author

Will be merging this after CI goes all green

@knyghtmare knyghtmare merged commit 94cb1d4 into wesnoth:master Oct 31, 2021
@knyghtmare knyghtmare deleted the wc-era-new-factions branch December 8, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Enhancement Issues that are requests for new features or changes to existing ones. MP Issues with multiplayer support or bundled multiplayer content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[World Conquest] [1.17] Add one or two Dunefolk-X pair factions into WC era to complete it.
1 participant