UtBS S08 Kromph and Dust Devil able to trigger Eloh's event

[Descacharrado]

The variable talking_unit is used instead of unit to set the speaker in many messages.

The talking unit that talks on behalf of the monsters can be, in this order: An elf in the map, a recalled elf, a forcedly spawned elf (Lines 3007-3067)

That unit will move to the dunes to fit the dialogue (Lines 3124-3137)

EDIT: fixed on 061a42b:

I found that code at line 3024 was not searching for units on the recall list
Also if a unit was on 19 20 previously, it would get the talker role, even if it was not intended.
Also the unit which gets created in case everything else fails could get stuck in a wall

Another thing I found testing is that skeletons in one of the events can get stuck on the wall if you walk to their spawning positions maybe fixable on another PR.

Closes #6211

[nemaara]

Maybe wants @knyghtmare to look too.

[knyghtmare]

Maybe wants @knyghtmare to look too.

Seems like it can be merged in. I only commented.

[Wedge009]

One thing I noticed while testing this is that the Dust Devil is excluded from triggering pretty much any event in S8, and probably most other scenarios too. But I suppose that generally isn't a problem except in the unusual circumstance where it travels far beyond the rest of Kaleh's party, and it only seems to be an issue in special cases such as what #6211 reports.

Anyway, the changes seem to work for me. Unfortunately the back-port will have to wait till after the string freeze since it does touch one translated string - even though no words are meaningfully changed here.

[Descacharrado]

One thing I noticed while testing this is that the Dust Devil is excluded from triggering pretty much any event in S8, and probably most other scenarios too.

I will test all S08s events thoroughly and open an issue with all weird things I find, then proceed to fix them if no one else does, as I said:

Skeletons in one of the events can get stuck on the wall if you walk to their spawning positions

Also true, didn't notice, sry:

Unfortunately the back-port will have to wait till after the string freeze since it does touch one translated string - even though no words are meaningfully changed here.

[Wedge009]

1.16.2 string freeze is over - are we waiting for anything before merging this?

[Wedge009]

Ah, I just noticed this has already been approved and I did test the change beforehand, so will merge.