DM S14 Smooth undead appearance and add dialogue #6429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Campaign (any)
knyghtmare
reviewed
Jan 9, 2022
Wedge009
added
the
Backport
Wedge009
reviewed
Jan 10, 2022
|
This is at least better than the sudden spawn that currently happens. And yes, as mentioned, the back-port will have to wait until after the 1.16.2 string freeze is over, although this PR to master can be merged any time. |
nemaara
approved these changes
Jan 13, 2022
Wedge009
pushed a commit
that referenced
this pull request
Jan 16, 2022
(cherry picked from commit 939a1b1)
Asheviere
pushed a commit
to Asheviere/wesnoth
that referenced
this pull request
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add postponed label due to string freeze.
Changes:
Changed the event comment (as beating the enemy leader is allowed and accounted for on lines 349+) (Line 331).
Added a dialogue to explain a bit why they are being spawned (Lines 332-335) (string could be changed before merging)
And added
animate=yesto enemy spawning (Lines 337-339, 341-343)Closes #6176