TRoW S22 Fixed the possibility of a missplaced dialogue when a bridge was broken #6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Campaign (any)
nemaara
approved these changes
Jan 10, 2022
Wedge009
added
the
Backport
Descacharrado
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New behaviour:
When no units are in the "island" north of the bridge, "retreat" is said instead of "advance".
If there are units on both sides of the bridge, (even if it is only one, minor level 1 unit) the word advance takes priority over retreat. As stated on the issue, it is such a minor possibility that it does not matter if the condition is simple, as long as it does not feel weird when the dialogue is triggered (at least, that is my opinion).
Also remember string freeze if backported.
Closes #6376