Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black Nightmare: add a translation hint for this unit's name #6443

Merged
merged 1 commit into from Jan 16, 2022
Merged

Black Nightmare: add a translation hint for this unit's name #6443

merged 1 commit into from Jan 16, 2022

Conversation

stevecotton
Copy link
Contributor

No description provided.

@stevecotton stevecotton added the Units Issues that involve unit definitions or their implementation in the engine. label Jan 13, 2022
@stevecotton stevecotton self-assigned this Jan 13, 2022
@Wedge009
Copy link
Member

Huh, even in English that subtle reference would be lost on me as I've seen ghostly horses called nightmares in other games. But I agree with the change.

@Wedge009 Wedge009 added the Fwdport A reminder of a bugfix that was added to the stable branch that needs to be duplicated on master. label Jan 14, 2022
@stevecotton stevecotton added the Postponed Issues which cannot be worked on at this time. label Jan 14, 2022
@stevecotton
Copy link
Contributor Author

Even though it doesn't change the translatable strings, it makes more sense to drop this in just after 1.16.2 releases rather than just before it.

doofus-01
doofus-01 approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@doofus-01 doofus-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment/hint is not untrue, and if it helps the translators, it's good to have.

@stevecotton stevecotton merged commit b825c3f into wesnoth:1.16 Jan 16, 2022
@stevecotton stevecotton deleted the nightmare_po_hint branch January 16, 2022 19:20
@Pentarctagon Pentarctagon removed the Postponed Issues which cannot be worked on at this time. label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doofus-01 doofus-01 doofus-01 approved these changes

Assignees

@stevecotton stevecotton

Labels
Fwdport A reminder of a bugfix that was added to the stable branch that needs to be duplicated on master. Units Issues that involve unit definitions or their implementation in the engine.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stevecotton @Wedge009 @doofus-01 @Pentarctagon