Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[world conquest] Fix for HP glitch when picking up items/artifacts #6454

Merged
merged 1 commit into from Jan 18, 2022
Merged

[world conquest] Fix for HP glitch when picking up items/artifacts #6454

merged 1 commit into from Jan 18, 2022

Conversation

knyghtmare
Copy link
Member

Fixes 7th bug of #6411

@github-actions github-actions bot added the Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign label Jan 18, 2022
@knyghtmare knyghtmare added the MP Issues with multiplayer support or bundled multiplayer content. label Jan 18, 2022
@knyghtmare knyghtmare moved this from Issues to Pull Requests in Improving World Conquest Jan 18, 2022
@knyghtmare knyghtmare added the Backport A reminder of a bugfix that was added to master that needs to be duplicated on the stable branch. label Jan 18, 2022
@Discontinuum
Copy link
Contributor

Tbh, I don't understand how
--rebuild unit, to reduce savefile size. unit:transform(unit.type)
helps to reduce the savefile size. While it's causing the hp thing

@knyghtmare
Copy link
Member Author

Tbh, I don't understand how --rebuild unit, to reduce savefile size. unit:transform(unit.type) helps to reduce the savefile size. While it's causing the hp thing

No clue. I have zero cpp knowledge.

@knyghtmare knyghtmare merged commit 9e7b388 into wesnoth:master Jan 18, 2022
@knyghtmare knyghtmare deleted the wc-fix-artifact-hp-glitch branch January 18, 2022 17:11
@stevecotton
Copy link
Contributor

This was backported in cebcd65, but with the possibility of OOS I'm wondering if we need to revert it :(

@Pentarctagon Pentarctagon moved this from Pull Requests to Resolved in Improving World Conquest Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backport A reminder of a bugfix that was added to master that needs to be duplicated on the stable branch. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign MP Issues with multiplayer support or bundled multiplayer content.
Projects
Improving World Conquest
Resolved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knyghtmare @Discontinuum @stevecotton