Add /clear chat command #6457
Merged
Add /clear chat command #6457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevecotton
reviewed
Jan 24, 2022
stevecotton
reviewed
Jan 24, 2022
stevecotton
requested changes
Jan 24, 2022
There was a problem hiding this comment.
Welcome to the project, but sadly this crashes when used in the MP lobby's chatbox. I've just added a screenshot to #3202 showing which screen I mean.
For in-game chat, I think it's good to have /clear work here too. There's already a :clear command, but having both is user-friendly.
Wedge009
added
the
UI
macabeus
force-pushed
the
add/clear-command
branch
from
e10dca5
to
0f66a83
Compare
|
Sorry, but the latest version still crashes when Steps:
|
|
@stevecotton Yeah. I got to reproduce it, but I'm wondering how to fix it. I noticed the lobby chat is pretty different. |
|
@stevecotton I hope it's working well now Jan-26-2022.00-42-38.mp4 |
stevecotton
reviewed
Jan 26, 2022
macabeus
force-pushed
the
add/clear-command
branch
from
c1ff4c4
to
14bcc2a
Compare
stevecotton
approved these changes
Jan 30, 2022
macabeus
added a commit
to macabeus/wesnoth
that referenced
this pull request
Jan 31, 2022
Asheviere
pushed a commit
to Asheviere/wesnoth
that referenced
this pull request
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #3202
Add
/clearchat commandJan-23-2022.22-54-15.mp4